Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Jul 2021 14:48:42 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Andrea Merello <andrea.merello@gmail.com>
Cc:     Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        linux-kernel@vger.kernel.org, Yury Norov <yury.norov@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andrea Merello <andrea.merello@iit.it>
Subject: Re: [PATCH v1 1/1] bitmap.h: add const modifier to
 bitmap_next_[set/clear]_region() argument
Message-ID: <YP/ymvrd1zV7z6rF@smile.fi.intel.com>
References: <20210727094441.9815-1-andrea.merello@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210727094441.9815-1-andrea.merello@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Jul 27, 2021 at 11:44:41AM +0200, Andrea Merello wrote:
> Those two functions don't modify the bitmap, so their bitmap argument
> should be const. This patch add this.

Constification is always a good thing. No objections from me,
although Yuri is doing something with them in one of his patch series.

Yuri, do you have a public repo / branch that people can base their changes to
bitmap stuff against of?

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Andrea Merello <andrea.merello@iit.it>
> ---
>  include/linux/bitmap.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index a36cfcec4e77..ea4a8f1a2545 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -458,7 +458,7 @@ static inline void bitmap_replace(unsigned long *dst,
>  		__bitmap_replace(dst, old, new, mask, nbits);
>  }
>  
> -static inline void bitmap_next_clear_region(unsigned long *bitmap,
> +static inline void bitmap_next_clear_region(const unsigned long *bitmap,
>  					    unsigned int *rs, unsigned int *re,
>  					    unsigned int end)
>  {
> @@ -466,7 +466,7 @@ static inline void bitmap_next_clear_region(unsigned long *bitmap,
>  	*re = find_next_bit(bitmap, end, *rs + 1);
>  }
>  
> -static inline void bitmap_next_set_region(unsigned long *bitmap,
> +static inline void bitmap_next_set_region(const unsigned long *bitmap,
>  					  unsigned int *rs, unsigned int *re,
>  					  unsigned int end)
>  {
> -- 
> 2.17.1
> 

-- 
With Best Regards,
Andy Shevchenko