Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4352288pxv; Tue, 27 Jul 2021 05:27:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySBhyUYTm40PJ3rMXkoGps/LT6jqOpaoEqIqMnrOgLoBFTZd+/E4MJ8tOyLmJAr/ptMrmg X-Received: by 2002:a02:6f1c:: with SMTP id x28mr21501675jab.95.1627388850016; Tue, 27 Jul 2021 05:27:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627388850; cv=none; d=google.com; s=arc-20160816; b=iCf2fOryaAdupgRW2hhDNlzjXbdKckvO0sDcMDtvIKVskw+7SEOKUm4D0X2ZTU0IQ3 +qaJxpe2tFvy/SXHDHXNckkyzUvU3mCtW/oOj2QtpHw7+hxyRLbuqMOk4UCbs4W6ei/C VklOAN04oAlXp3EJNHO+OCZ6sKFOHSWs5ny9sWDFW30fpaGL8oxppcWhJstZkQcC2OkI GeVO7XhMB/nptF0wFIo+TY3dUtsGrgIi1b68FEkHeZhOhb2aMDoIdgKCWjbiXTvbVx+Z el/rIFnsiOYDyo/eTzPzuE1Bz7UhrqW47sqtpwAoCe8QWJjoncVOTki8btb2NdSYEeu5 t6tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=N3cKMq7FQrIxMFvYOEgWiA8gT81qg1YUKkt69yUwTVs=; b=LA4NcGsfVCxt63fnxiMzNKHgT49iYvid6zFT+WHalA7B9XqQIhC3E0C3g3wn7xZGPk cXECwNpKdMUtp/98GFkeDxVVfhD8J6/ZKZh7YpApfSXnLE5/U6dVbS8hXge0ajQMhtWq y2KoUGPDmc90jFAW3FDdN2T6/clRy7tIwIW1YeMn0B9mRJJVs/7Do+lguq1pOvzVloZR GS3KR3Q10MxiYg/spfdzLV/De92xCLulWLp/p+DnD8Kc5TxYdhLljwMwrmQye0o3fDBG EnAXQRb0DuaBOAMIZ8vqs8Pnmdr/ZosIN9jmngKxapKYXeaggaHmA2dL3mFKwIoCexK8 ussA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si4007542ioo.75.2021.07.27.05.27.17; Tue, 27 Jul 2021 05:27:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236441AbhG0MYx (ORCPT + 99 others); Tue, 27 Jul 2021 08:24:53 -0400 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:25704 "EHLO cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231945AbhG0MYv (ORCPT ); Tue, 27 Jul 2021 08:24:51 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.13]) by rmmx-syy-dmz-app10-12010 (RichMail) with SMTP id 2eea60fffae9c01-993fb; Tue, 27 Jul 2021 20:24:14 +0800 (CST) X-RM-TRANSID: 2eea60fffae9c01-993fb X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr07-12007 (RichMail) with SMTP id 2ee760fffae9a02-874d5; Tue, 27 Jul 2021 20:24:14 +0800 (CST) X-RM-TRANSID: 2ee760fffae9a02-874d5 From: Tang Bin To: k.opasiak@samsung.com, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin , Zhang Shengju Subject: [PATCH] nfc: s3fwrn5: fix undefined parameter values in dev_err() Date: Tue, 27 Jul 2021 20:25:06 +0800 Message-Id: <20210727122506.6900-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the function s3fwrn5_fw_download(), the 'ret' is not assigned, so the correct value should be given in dev_err function. Fixes: a0302ff5906a ("nfc: s3fwrn5: remove unnecessary label") Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/nfc/s3fwrn5/firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c index 1421ffd46d9a..52c6f76adfb2 100644 --- a/drivers/nfc/s3fwrn5/firmware.c +++ b/drivers/nfc/s3fwrn5/firmware.c @@ -422,7 +422,7 @@ int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info) tfm = crypto_alloc_shash("sha1", 0, 0); if (IS_ERR(tfm)) { dev_err(&fw_info->ndev->nfc_dev->dev, - "Cannot allocate shash (code=%d)\n", ret); + "Cannot allocate shash (code=%d)\n", PTR_ERR(tfm)); return PTR_ERR(tfm); } -- 2.18.2