Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <00527c09b0d4f22652f9cd5c2fde4e091df2d610.camel@linux.intel.com>
Subject: Re: [PATCH v2] platform/x86/intel: Move Intel PMT drivers to new
 subfolder
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Joe Perches <joe@perches.com>, hdegoede@redhat.com,
        mgross@linux.intel.com, andriy.shevchenko@linux.intel.com
Cc:     linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Date:   Tue, 27 Jul 2021 07:53:41 -0700
In-Reply-To: <45ccb9e8c610678e72f461b1e9d61de0a4c9bc79.camel@perches.com>
References: <20210727022550.3083745-1-david.e.box@linux.intel.com>
         <45ccb9e8c610678e72f461b1e9d61de0a4c9bc79.camel@perches.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-07-26 at 20:36 -0700, Joe Perches wrote:
> On Mon, 2021-07-26 at 19:25 -0700, David E. Box wrote:
> > Move all Intel Platform Monitoring Technology drivers to
> > drivers/platform/x86/intel/pmt.
> []
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -9494,7 +9494,7 @@ INTEL PMT DRIVER
> >  M:     "David E. Box" <david.e.box@linux.intel.com>
> >  S:     Maintained
> >  F:     drivers/mfd/intel_pmt.c
> > -F:     drivers/platform/x86/intel_pmt_*
> > +F:     drivers/platform/x86/intel/pmt/*
> 
> Unless you are suggesting you are not maintainer of any files
> in any subdirectories below this directory, you should not use
> a *
> 
> F:      drivers/platform/x86/intel/pmt/

Ack

> 
> > diff --git a/drivers/platform/x86/intel/Makefile
> > b/drivers/platform/x86/intel/Makefile
> []
> > @@ -7,3 +7,4 @@
> >  obj-$(CONFIG_INTEL_CHT_INT33FE)                += int33fe/
> >  obj-$(CONFIG_INTEL_SKL_INT3472)                += int3472/
> >  obj-$(CONFIG_INTEL_PMC_CORE)           += pmc/
> > +obj-y                                  += pmt/
> 
> This seems odd.  Perhaps:
> 
> obj-$(CONFIG_PMT_CLASS)                         += pmt/

This would work.

Thanks