Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/3] arm: include: asm: swab: mask rev16 instruction for
 clang
To:     Pavo Banicevic <pavo.banicevic@sartura.hr>,
        <linux@armlinux.org.uk>, <ast@kernel.org>, <daniel@iogearbox.net>,
        <andrii@kernel.org>, <kafai@fb.com>, <songliubraving@fb.com>,
        <john.fastabend@gmail.com>, <kpsingh@kernel.org>,
        <nathan@kernel.org>, <ndesaulniers@google.com>,
        <ivan.khoronzhuk@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <bpf@vger.kernel.org>, <clang-built-linux@googlegroups.com>,
        <matt.redfearn@mips.com>, <mingo@kernel.org>,
        <dvlasenk@redhat.com>, <juraj.vijtiuk@sartura.hr>,
        <robert.marko@sartura.hr>, <luka.perkov@sartura.hr>,
        <jakov.petrina@sartura.hr>
References: <20210727141119.19812-1-pavo.banicevic@sartura.hr>
 <20210727141119.19812-2-pavo.banicevic@sartura.hr>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <424add3f-d79a-79dd-2e6a-dbb966bf7349@fb.com>
Date:   Tue, 27 Jul 2021 08:46:23 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.12.0
In-Reply-To: <20210727141119.19812-2-pavo.banicevic@sartura.hr>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2620:10d:c085:21c8::1398] (2620:10d:c090:400::5:4698) by SJ0PR03CA0257.namprd03.prod.outlook.com (2603:10b6:a03:3a0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.26 via Frontend Transport; Tue, 27 Jul 2021 15:46:25 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ed5593dd-066b-41f8-5ad6-08d95115b1c4
X-MS-TrafficTypeDiagnostic: SN7PR15MB4176:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SN7PR15MB4176A8B0D22E0801863756F9D3E99@SN7PR15MB4176.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: NlPjqn1lJQBv7831THrxCOxijGP98oiPWbHatTiWQlY4k+RlaKFNrlLUXpng65+Szhj5XjWSU/LxaAV6YVudxL+N+E0nhd5nC7ZLwEIbwa2MZ7NIVGaw8k5Xu+sia31ccoir5sGZ1Ab6MZIhswoVHfWqRkK3ntan4r3mNZMBvL9L69ojgR7+EDpsPrOSoGCbl62v9biZuQ9BNPkI7ZVk04uYQIVLiMZdhldzpookoDOCkfqa7A4+Imfh5aXXxVOjti2Er+0vgHvzpnimdrDH76ZK8G9jOASTcRe1YAcWs93sLFqCIwWJuNLOtVZHtWzG1bodoT9G8nRnuY6dRziEgxV53SGTxQ4ckcAJWhIR63KT8Zm6rTcQHqPDlaG7EkbJC9z36FbrCjvuPp6FBRtEJPKxsdMRHu/tQ1A5fDhxL/aFAILie0mGXNKboHrPURbeV7gDKen9V5b52j7/Nx8NUYCeXUzZ9S7JgKE2P7tJuRTBZy8+TYbzMKAkg+4bssLD1rNbdIjMwFHt6r9WpwRY74rZFv7mZOqfEJ/ObMUJJveSCvCUWNwhiTRowuUVQqWH9bOmt5IKIUudvQ4x1Rco0p2en0msi65Lz0+sN9oUXGPakdBaTf1Iqbk/FBx8d2yP5b7ykwzPq/EC9nq3LPQLRe877HxREay+DFbuLbYT6OI1bIwC0uyB8XqGTbQ4nGPqBz/vDHpEqC2ki+AgSwRwS1yViM7sr/bwG5p4ksDVPsXy3CoRiMEh/ikIe8P8cWvP
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR1501MB2064.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(2616005)(36756003)(53546011)(2906002)(86362001)(6486002)(186003)(8676002)(478600001)(66946007)(66476007)(52116002)(66556008)(8936002)(7416002)(921005)(31686004)(31696002)(5660300002)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MCtJeUluc3JzTmp4K1RyNTU3V1R5RHUwOUtmZkF4UGYzcUNRWkoyL1JtdjlC?=
 =?utf-8?B?Q2tucnFzZmdwdElJZERub0pjQnJTS1lqc0EyUnZtb3Y1R1hBcEFlZUUzNTVh?=
 =?utf-8?B?UU5Sb2J6NzZrUEFzZzRvdG8zTDVTSTdkeVJ0V2tDN21IVjVBZDlBd0NBVlJq?=
 =?utf-8?B?ZzJIbWtSMityQ1ZZKzBQSEs3QnZldVlTSkNYM2kyMG0xdlRnbmVMdFVheEFu?=
 =?utf-8?B?b2I2cTVNLzgzdU02U2pKb0RsR3dtUGVCUEp4RFRsSDdkWUlVWWRtb0k2b0NX?=
 =?utf-8?B?cXp5TzZUQVhnNDhoaldCSXUwS0xGaGdxZEE5bnI2Y3o3bjQ3UkxMbmE5aEk1?=
 =?utf-8?B?allkY0dzbXdNRlphTXBBTnVJbGp0Yy9Zd1FUT3NnTHZFaDMzNW5IMTdxMTYy?=
 =?utf-8?B?bk1aRmFKMzgwM1orNVpGay9DRFJGcHgxbmRXOUgyUzF6d0ZGWGMrT2JaS25O?=
 =?utf-8?B?Q2JOdFJURUp4Y3JTclYrZnVjYjBFbzlYNlB5dy9mcmZHb2RsMkpUQUY0VHBQ?=
 =?utf-8?B?NjdkS2JaeVZoUVhZdS90eCtQSmlGbGxmWGhVK0hFbXJoV215RDFxZWF6Z0xo?=
 =?utf-8?B?eUVCUFRwZ3lXTnJyV1FyUmxYdDhubTlORk1IcjVVNEFndjRQc0lCNjliczZP?=
 =?utf-8?B?MWxXTkUyaTRRTnFabDJFZXd3M24zU2NFSjA5NXNtWWhIUmpPTFhGUnRzQm5V?=
 =?utf-8?B?R1k2TmJZenM3WUg0YlJaTGxHZVVpY0lXWEpGQ2xWUTBTL3V0N1VxeGVCemQ2?=
 =?utf-8?B?ZGI1KzNqTnhTRWVCbVRQZVVTdEkzN2ZKcm13RlYzcGMzaTZ3MmpSQklMNmRM?=
 =?utf-8?B?dHpRUDE4V2dkczNGeU1ZSFJhVzNBT1E4VlpDaEY5b3I3U2hFaFhhVkRrYzho?=
 =?utf-8?B?UWtVbUNEVVRvVWpYTGNaMjBrU1RqSWxPNlFPQklTOFprWTNURVo4RHJqOSsx?=
 =?utf-8?B?Q3RjTXBIYkcwSEtPc1RERVNYdkFWZjN0UjZLcFpGWEc2NkVNdVZIeEw4NGlt?=
 =?utf-8?B?WVAxeXp5ZE9SWVdQQUw3T3pXU0RJekNLNS8vY1hwL25nYVJ6ZVFieU1tNnpr?=
 =?utf-8?B?YmVNN1ppQjZLQXF3Wit3VHZPTUNJdkI4SW9Sd25JanVjU2ZpbFlieDZaQWpn?=
 =?utf-8?B?MTVPWGJkQnE1eER2Y1JEV3AyWXNZV0c4eU81RG9yUHo1QnBtVU44TDdocmdr?=
 =?utf-8?B?VDNmeTh6YmpleEFsT0toUVM2MW5mZ2U0UlBYeWVYSEZ4djRyVGwrQ2FocTBB?=
 =?utf-8?B?aFNMNFlROUNaRTVIVjY5TEhRdC9hL0t5SnRsRmVuVkQxU3p5bDdoNFFZd2RT?=
 =?utf-8?B?QmdKZVZkdThvMExFcHE4cHpjMGFaZ0lLckw3Zk9ZOHFRZDJOdFpFUS9mUkpD?=
 =?utf-8?B?Wnd0dDA5eG5QMlpvMVdGZEFuS04weXYwT3NrRnNLRlpOdnJldUplNlNrcHRi?=
 =?utf-8?B?K3F2dlp0QVBFVlp4T1VsMDdsbCthbkZXWFd1VjVSWVBCZWpGOWZHYlowQytZ?=
 =?utf-8?B?bTRyM3hxODA4eDVjN2hKZG1EZ3RsWEJzSFdqOUx4Y2wxMmdCUWlrT3A4bWZ3?=
 =?utf-8?B?cytRenNWaTZyTWJZWmdSYVVzY1NqTm56OWhIWGk2TGhhMktOd3VYUm4wcDAx?=
 =?utf-8?B?eXZqU3RCeG92QkRlMlplbzU4UStJN3V5cjlLdExVYU9TbXZhd252YnRGU2tN?=
 =?utf-8?B?SUFNREtJbVQreUdHa0VhZkxHb2ppVkpTT2drQTF5MmhuVGpaQVpMWlVaK0JO?=
 =?utf-8?B?bnNzOHBYSHZSUXVWVWZlMFJBbzc2Y3doallmQzlMWUQwem5Va2RuN01xeCtl?=
 =?utf-8?B?U2dmSTAxcDM0Y1UwTytvQT09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ed5593dd-066b-41f8-5ad6-08d95115b1c4
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2021 15:46:26.9993
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1kFwau23EySKr4z1jFZY+IKsypC3+MADhunEWMNRM1hKrZX2vPVrmhyGTNgKZr30
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR15MB4176
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: pe_1I5CukfauFBJHpx04hDyv0lUAcAgo
X-Proofpoint-ORIG-GUID: pe_1I5CukfauFBJHpx04hDyv0lUAcAgo
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-07-27_10:2021-07-27,2021-07-27 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxlogscore=999
 malwarescore=0 adultscore=0 impostorscore=0 lowpriorityscore=0
 clxscore=1011 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0
 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2107140000 definitions=main-2107270094
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/27/21 7:11 AM, Pavo Banicevic wrote:
> From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> 
> The samples/bpf with clang -emit-llvm reuses linux headers to build
> bpf samples, and this w/a only for samples (samples/bpf/Makefile
> CLANG-bpf).
> 
> It allows to build samples/bpf for arm bpf using clang.
> In another way clang -emit-llvm generates errors like:
> 
> CLANG-bpf  samples/bpf/tc_l2_redirect_kern.o
> <inline asm>:1:2: error: invalid register/token name
> rev16 r3, r0
> 
> This decision is arguable, probably there is another way, but
> it doesn't have impact on samples/bpf, so it's easier just ignore
> it for clang, at least for now.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>   arch/arm/include/asm/swab.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/include/asm/swab.h b/arch/arm/include/asm/swab.h
> index c6051823048b..a9fd9cd33d5e 100644
> --- a/arch/arm/include/asm/swab.h
> +++ b/arch/arm/include/asm/swab.h
> @@ -25,8 +25,11 @@ static inline __attribute_const__ __u32 __arch_swahb32(__u32 x)
>   	__asm__ ("rev16 %0, %1" : "=r" (x) : "r" (x));
>   	return x;
>   }
> +
> +#ifndef __clang__
>   #define __arch_swahb32 __arch_swahb32
>   #define __arch_swab16(x) ((__u16)__arch_swahb32(x))
> +#endif

What if the kernel is compiled with clang compiler?
Does this still work?

To workaround samples/bpf issue, I think you can use
__BPF_TRACING__ macro.

>   
>   static inline __attribute_const__ __u32 __arch_swab32(__u32 x)
>   {
>