Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4512075pxv; Tue, 27 Jul 2021 09:05:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvjei8Mak90EKxFCBsQacVhaFAnG0TsZ64smKUfqF8xh3JWvfHFjUNceB3zuqG6BiuHli/ X-Received: by 2002:a5e:c109:: with SMTP id v9mr19706383iol.76.1627401944518; Tue, 27 Jul 2021 09:05:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627401944; cv=none; d=google.com; s=arc-20160816; b=Ktt8FdJZR0QUCv63Sw32z2qipyftnAG3e8SavO9Ynrzs2WreMm1mqAql03A2kBlQv0 QJ1In6CF9OVq0iof3ZPtosayxoOP6m1xBNimtPJEkAWKgbPrU3voKJROjPXspg+O0bAn HLZ+gT51n2uTtZpHxeRkrUYIA9VsCkB14cpUzuAkL5/fsRJxuxWktHwZFW1TsRfDhluw wYmy4Mxkx76OPAd7q0MvBlxm5zHF4AHMuFqun3rP5McvyU7B1PEeHA8VErNaceQCzvmk Rjp+Db7YOQoy7lOydH5yfBl4gGHZ1u05lpKshUQ49f0tPmP8cEOGWCNPyw3HHkjtfdQj rTew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:organization:message-id:date:subject:cc:to :from; bh=HAJgtqMDmbkQA9Z/mU9J1QbLhiyC6T17dW/OSoGCJsk=; b=tPVOAluuD2JEjw7xdbS43YMh39fTjD1uYN471JWIYPcaAfzf3pl2CxPYSpusDlGN3w kteWR2NPMuv8mcp9buJcYMmsBwyN79OMuGh4TmuyR22urDiYtiOrLC9xXnwBTetrWog1 ciinwig4DQkHfuf//9YjUbwgFs1aLAaSkHYfCgLBlCjdRyYulEZOsDS8h9OlQExyD4p+ QfplJzV6VFSZHHrzmIYeT6QTV9cnAyS2ZIfv66NPWi4djZIRyrFmdCLsPlj/uhBGG3GY 9RMsISTXZztrfeY+N6kT07duZ/B6WuhH8kfeXbsXtK+ovqb1+eKW/AuXKUyx0RXlSwO6 BjIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m8si3567487jav.78.2021.07.27.09.05.31; Tue, 27 Jul 2021 09:05:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbhG0QDh convert rfc822-to-8bit (ORCPT + 99 others); Tue, 27 Jul 2021 12:03:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229759AbhG0QDf (ORCPT ); Tue, 27 Jul 2021 12:03:35 -0400 Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [IPv6:2001:41d0:305:2100::8a0c]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 51098C061757 for ; Tue, 27 Jul 2021 09:03:35 -0700 (PDT) Received: from ursule.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 50E7AC0241; Tue, 27 Jul 2021 19:03:33 +0300 (EEST) Received: from basile.remlab.net ([2001:14ba:a01a:be01:9434:f69e:d553:3be2]) by ursule.remlab.net with ESMTPSA id sRsREVUuAGFWcAAAwZXkwQ (envelope-from ); Tue, 27 Jul 2021 19:03:33 +0300 From: =?ISO-8859-1?Q?R=E9mi?= Denis-Courmont To: netdev@vger.kernel.org, Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Jakub Kicinski , "David S. Miller" , Arnd Bergmann , Remi Denis-Courmont Subject: Re: [PATCH net-next v3 06/31] phonet: use siocdevprivate Date: Tue, 27 Jul 2021 19:03:32 +0300 Message-ID: <1745398.PdPXp2ZHHY@basile.remlab.net> Organization: Remlab In-Reply-To: <20210727134517.1384504-7-arnd@kernel.org> References: <20210727134517.1384504-1-arnd@kernel.org> <20210727134517.1384504-7-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le tiistaina 27. heinäkuuta 2021, 16.44.52 EEST Arnd Bergmann a écrit : > From: Arnd Bergmann > > phonet has a single private ioctl that is broken in compat > mode on big-endian machines today because the data returned > from it is never copied back to user space. > > Move it over to the ndo_siocdevprivate callback, which also > fixes the compat issue. > > Cc: Remi Denis-Courmont > Signed-off-by: Arnd Bergmann Acked-by: Rémi Denis-Courmont -- This made me realise that the HSI/SSI device driver lacks the private IOCTL (but that's obivously not a problem of this series). -- Rémi Denis-Courmont http://www.remlab.net/