Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: connector: Add pd-supported property
To:     Kyle Tso <kyletso@google.com>, heikki.krogerus@linux.intel.com,
        gregkh@linuxfoundation.org, robh+dt@kernel.org
Cc:     badhri@google.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20210727151307.2178352-1-kyletso@google.com>
 <20210727151307.2178352-2-kyletso@google.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <482e2770-f371-9755-f125-96b4cf11c2e3@roeck-us.net>
Date:   Tue, 27 Jul 2021 09:29:17 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210727151307.2178352-2-kyletso@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/27/21 8:13 AM, Kyle Tso wrote:
> Set pd-supported property if the Type-C connector has power delivery
> support.
> 
> Signed-off-by: Kyle Tso <kyletso@google.com>
> ---
>   .../devicetree/bindings/connector/usb-connector.yaml         | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 92b49bc37939..8ed271feea08 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -111,6 +111,10 @@ properties:
>         - 1.5A
>         - 3.0A
>   
> +  pd-supported:

I think that would have to be a property indicating that pd is _not_
supported, for compatibility reasons. Otherwise all existing bindings
would indicate that pd is not supported.

> +    description: Set this property if the Type-C connector has power delivery support.
> +    type: boolean
> +
>     # The following are optional properties for "usb-c-connector" with power
>     # delivery support.
>     source-pdos:
> @@ -312,6 +316,7 @@ examples:
>           label = "USB-C";
>           power-role = "dual";
>           try-power-role = "sink";
> +        pd-supported;
>           source-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_USB_COMM)>;
>           sink-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_USB_COMM)
>                        PDO_VAR(5000, 12000, 2000)>;
>