Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Jul 2021 18:30:28 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Chen Wandun <chenwandun@huawei.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com,
        weiyongjun1@huawei.com
Subject: Re: [PATCH] mm/vmalloc: add missing __GFP_HIGHMEM flag for vmalloc
Message-ID: <YQBCtHv1qD4Pinw/@casper.infradead.org>
References: <20210726032333.3404164-1-chenwandun@huawei.com>
 <YP4rM7qtSet+H+nG@casper.infradead.org>
 <f064b046-8831-2aa9-2234-63e867e28dc1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f064b046-8831-2aa9-2234-63e867e28dc1@huawei.com>
Precedence: bulk

On Mon, Jul 26, 2021 at 12:05:44PM +0800, Chen Wandun wrote:
> 在 2021/7/26 11:25, Matthew Wilcox 写道:
> > On Mon, Jul 26, 2021 at 11:23:33AM +0800, Chen Wandun wrote:
> > > struct page array can also be allocated in highmem during vmalloc,
> > > that will ease the low memory stress in 32bit system.
> > Huh?  Where does it get kmapped in order to access it?

(i misread your patch, apologies)

> The struct page array contain numbers of pointer of struct page, it is used to save
> 
> pages that allocated for vmalloc mapping in vmap_pages_range, it does't need to kmap.
> 
> 
> The main idea of this patch is come from:
> 
> https://lore.kernel.org/lkml/20170307141020.29107-1-mhocko@kernel.org/

you've misunderstood that patch.  think about it:

static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
                                 pgprot_t prot, unsigned int page_shift,
                                 int node)
{
	const gfp_t nested_gfp = (gfp_mask & GFP_RECLAIM_MASK) | __GFP_ZERO;
(now nested_gfp has neither DMA nor DMA32 set)

        gfp_mask |= __GFP_NOWARN;
        if (!(gfp_mask & (GFP_DMA | GFP_DMA32)))
                gfp_mask |= __GFP_HIGHMEM;
(we set HIGHMEM if DMA and DMA32 are both not set)

                area->pages = __vmalloc_node(array_size, 1, nested_gfp, node,
                                        area->caller);
(we don't need to set HIGHMEM here because it will be set for us in
the second call to __vmalloc_area_node)