Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4585713pxv; Tue, 27 Jul 2021 10:53:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/t3uHJTe7iCJkYiVeaIT9Mq6obmjxR7tErJGbZqBN1kFeJ9IxQQY6qMSK/2O/d4cVnCph X-Received: by 2002:a05:6e02:1a67:: with SMTP id w7mr17321258ilv.175.1627408393491; Tue, 27 Jul 2021 10:53:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627408393; cv=none; d=google.com; s=arc-20160816; b=p7RVUAo+eFdJQ3lkvQh9yQAGWCFIsooDA4NkpTOFQ0PUIjiUtnog/qCMVX4cRtAWzN 88Ung94pk1at8VC3/hSoJe4I54HJ9rM3lBmLWsKrZP91I7jFlWouFyQefxgofneNWnWf RSHkI3EL35S3r0o68/yCRGrsEoEGPXxFM679HzOVuzR9Bk/Unvv7MrJIzRiaQY6ZBWhN urYM52HvW3YH890dRNYxRqTitGxdLnW97oQxiNu8ykMNWFAqqtni7lJZvTH0Bfo9usJ1 RqfYb+P9pYw10Vh2fiya4IhrxoTo51en6rEXjMD77aLIsYkLwxFiZHWjmrf7NIT3x6kd lPiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=LwYScmPim6tE/MDgrbNvahN0e/2bkCVHKdvM2oDO2hU=; b=slKRtDpTd1GbeTaMeEpxVPn0sctsX8GkVadsIBhFOzMtrWjRgU/Gd1i6Fb8rz5cGWm 81Kf0xM34rej9+NXky3cn1IvYwfcgULfH9CepuBct2t01cnvuUQSXwV7MjZa7GpOYSEP 46KgLbkY13uEGbT02xBtIl0e31ccr8SWczdcyjB94V2CytkOeCl7MQ5v675n3DsOp02n cbXu1vne77Kz9NqtoPtz3nHWGwETROvhQ1qPSjLhDwyvjiZZiqvuiu9w1ozfZAxY882r ODhejGYosFXQnU9rotkh66mRdPF14wzVtf9GZvKNEpTBexmUsmdaCK8M8uNb1eFTQMvp B0iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g24si3826880jaq.119.2021.07.27.10.53.00; Tue, 27 Jul 2021 10:53:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbhG0Rvh (ORCPT + 99 others); Tue, 27 Jul 2021 13:51:37 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:34305 "EHLO mail-wm1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbhG0Rvg (ORCPT ); Tue, 27 Jul 2021 13:51:36 -0400 Received: by mail-wm1-f49.google.com with SMTP id l4-20020a05600c1d04b02902506f89ad2dso2389220wms.1; Tue, 27 Jul 2021 10:51:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LwYScmPim6tE/MDgrbNvahN0e/2bkCVHKdvM2oDO2hU=; b=MtrhHyH1EXKfrApBmzExmtJ81J/XnuL7XiVCbcmvQKkxG+hXLKeZCmEfNXGbpWjY62 rX13lbYIsJ/+Vp4+lD3YnCoytkiz5++QgdO+fDn6ZGS1+kIuDLeXuiNl/IKOyg9N95uf SVFif8+8w+kXY8FGi+ldJGBX/CFY38eq6OxTKW+1PkVtzYqhLO5WD+qx+VMcMLC4wiif AH9neasCeL8+g+0ajfeGUCBXy5aAgSJeREzCcpD3EWxxdevIgqSwRMVBP0dSP4FQn7oH fYJWzZn5H/nH92iR/BIOKOCREACoR7ect04U+4QEKzLd4XWDXYhkT++jEwMxLnIyB0c7 3aDQ== X-Gm-Message-State: AOAM531zNZGoisjifNMTs2SH0cvfMU2nLGYTxVgKFB3dppdtTMB3ZUGo Bdxv3EC3fS5ttfEZIFz7YP4= X-Received: by 2002:a05:600c:4308:: with SMTP id p8mr5485552wme.45.1627408294068; Tue, 27 Jul 2021 10:51:34 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id q22sm3675211wmc.16.2021.07.27.10.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 10:51:33 -0700 (PDT) Date: Tue, 27 Jul 2021 17:51:31 +0000 From: Wei Liu To: Praveen Kumar Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, viremana@linux.microsoft.com, sunilmut@microsoft.com, nunodasneves@linux.microsoft.com Subject: Re: [PATCH v3] hyperv: root partition faults writing to VP ASSIST MSR PAGE Message-ID: <20210727175131.364fxm667marijdk@liuwe-devbox-debian-v2> References: <20210727104044.28078-1-kumarpraveen@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210727104044.28078-1-kumarpraveen@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 27, 2021 at 04:10:44PM +0530, Praveen Kumar wrote: [...] > > @@ -170,9 +185,21 @@ static int hv_cpu_die(unsigned int cpu) > > hv_common_cpu_die(cpu); > > - if (hv_vp_assist_page && hv_vp_assist_page[cpu]) > + if (hv_vp_assist_page && hv_vp_assist_page[cpu]) { > wrmsrl(HV_X64_MSR_VP_ASSIST_PAGE, 0); > The content of the MSR should be preserved; otherwise you hit the same fault for root kernel. Wei.