Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Jul 2021 12:01:16 -0600
From:   Alex Williamson <alex.williamson@redhat.com>
To:     Cornelia Huck <cohuck@redhat.com>
Cc:     Cai Huoqing <caihuoqing@baidu.com>, jgg@ziepe.ca,
        eric.auger@redhat.com, kevin.tian@intel.com,
        giovanni.cabiddu@intel.com, mgurtovoy@nvidia.com, jannh@google.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: Add "#ifdef CONFIG_MMU" for vma operations
Message-ID: <20210727120116.61ba8e25.alex.williamson@redhat.com>
In-Reply-To: <877dhb4svx.fsf@redhat.com>
References: <20210727034000.547-1-caihuoqing@baidu.com>
        <877dhb4svx.fsf@redhat.com>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 27 Jul 2021 18:35:14 +0200
Cornelia Huck <cohuck@redhat.com> wrote:

> On Tue, Jul 27 2021, Cai Huoqing <caihuoqing@baidu.com> wrote:
> 
> > Add "#ifdef CONFIG_MMU",
> > because vma mmap and vm_operations_struct depend on MMU  
> 
> vfio_pci already depends on MMU -- what problems are you trying to fix?

Exactly my question, we silenced the randconfig builds without
CONFIG_MMU in commit 2a55ca373501 ("vfio/pci: zap_vma_ptes() needs
MMU").  Surely there are prototypes for vma_area_struct regardless of
CONFIG_MMU and vfio-core having an mmap callback has no dependency on
vm_operations_struct.  Thanks,

Alex