Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4619996pxv; Tue, 27 Jul 2021 11:51:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRQ9VhApGxXPG7ICbMY/cZiMUxhZP255hF/A32c6BUNXBjrJGVlKnYz5Etak0PU4g6HEJL X-Received: by 2002:a92:2805:: with SMTP id l5mr17526344ilf.242.1627411872429; Tue, 27 Jul 2021 11:51:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627411872; cv=none; d=google.com; s=arc-20160816; b=XukbBhu15cZJd/ln2CFUbi9yZfB5mObO8qTgfC7P/F+ZN0CMKQ61agpD5b80DpEujR tgntjMDJx6vfeH630Ypwa2T6T08AI/WEJw4Yyt6w3z+IZYsCUKdWX8auLftf8BSM4v8n VOsHHwzoW+/AICvwq8T2ZNN0W66n4FY+3M9VJJmWtZ5sdjCvGnmLdCpf8pkoSWgQXmcm ratvunLl33ixXCjm5jHhBr86RfI57EGgEh3C8sCM8X2Ck17a9JS+GM0piNermvSDzdrI vW/dB6MQhgtzO1M+Uq6HIK5TuWYmOQX8EgVOUdqkkBzzHTwgEVXu2Heo4nHY2STwxGMx MFIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5hlNpsGIe7CSYdOw7biQn4zvt3NZhvNAI+imF55Vs9k=; b=oGe2oGd8yWTYP3GZ4Bnb95Mx51+iWFFnQng+BS2O5/Ofp7nb9upOlitlSxkJpYlvEn ZrrfNAxG2MyYOPemeXaB35A2V/i8XKgnqTThJ7oYyPwt4BUnUcYMcMUZr3xRa7YjuNrX w5gS64ghM6OgUq+Zwr+PowCmzU+n29bvb9SiqE5G7oW/RZGXVTdgGwR7wcwyepeWY+5r 4EPIQKxqomQXTt3ujeFhgujTDmJJY2L3BYgVV8L4IpAEcmzWX29INg5coBA+xYDZyS+0 ZQ2H/gd/WJrIAyV9BU8osK1unPMiD+49qYkuzzPflqh2oJ6D6N+jkntuSL0Zd8xpO0w7 zDSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aTvhKIKZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v19si3868764jat.76.2021.07.27.11.50.58; Tue, 27 Jul 2021 11:51:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aTvhKIKZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbhG0SuK (ORCPT + 99 others); Tue, 27 Jul 2021 14:50:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:42654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbhG0SuJ (ORCPT ); Tue, 27 Jul 2021 14:50:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 18F3260FE3; Tue, 27 Jul 2021 18:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627411809; bh=FEnwgSbKVXqz/f02D+yC03c3XbgdHc6UQnZBnRvCJ/M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=aTvhKIKZ1ioo9DG0Ec9o/GHguV1Ls8Zpgym6pDWcFaNRWivLNiLs3OTCrstGNfOKs GYBakEdIJ12kYhkUhqg+tOIolcIb5CzQ6OTuCoADjYmLiI25p4cgat6MWKirxMzBn/ 352r/ZmRWn/7CQHJO+JzH27w1AHj9B1xK/Nn0TewFpaj1y7GxvPnDYLkim5VS64g0V 06QFD449q6vX6wKDDryuRrutXpXvt77m9GnAp5mB+Al7hIqJmEj1teWUskJ7YYwsIn N+imzTNgxUezFzNwky77iBsCOYrkNrnlOcsOxOnroPd5ezkMaL9zUmOn/CumedaEML +L3MG8J2lY+Mw== Received: by mail-lf1-f51.google.com with SMTP id z2so23497586lft.1; Tue, 27 Jul 2021 11:50:09 -0700 (PDT) X-Gm-Message-State: AOAM532heSb7RK5bbGEQzFPUHQM1OAir3WbFsEk2kNDQHm009XvpN27z wn4NChedsuO829eBRGx5DPkgTp0dph5Ei8wAMqw= X-Received: by 2002:adf:e107:: with SMTP id t7mr26004543wrz.165.1627411796641; Tue, 27 Jul 2021 11:49:56 -0700 (PDT) MIME-Version: 1.0 References: <20210727144859.4150043-1-arnd@kernel.org> <20210727144859.4150043-5-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Tue, 27 Jul 2021 20:49:40 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 4/6] mm: simplify compat numa syscalls To: Heiko Carstens Cc: Andrew Morton , Arnd Bergmann , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Vasily Gorbik , Christian Borntraeger , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "the arch/x86 maintainers" , "H. Peter Anvin" , Al Viro , "Eric W. Biederman" , Christoph Hellwig , Feng Tang , Linux ARM , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linuxppc-dev , linux-s390 , sparclinux , linux-arch , Linux API , Linux-MM , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 27, 2021 at 8:38 PM Heiko Carstens wrote: > > -268 common mbind sys_mbind compat_sys_mbind > -269 common get_mempolicy sys_get_mempolicy compat_sys_get_mempolicy > -270 common set_mempolicy sys_set_mempolicy compat_sys_set_mempolicy > +268 common mbind sys_mbind sys_mbind > +269 common get_mempolicy sys_get_mempolicy sys_get_mempolicy > +270 common set_mempolicy sys_set_mempolicy sys_set_mempolicy > > would remove compat_ptr() conversion from nmask above if I'm not mistaken. Maybe I'm misremembering how compat syscalls work on s390. Doesn't SYSCALL_DEFINEx(sys_mbind) still create two entry points __s390x_sys_mbind() and __s390_sys_mbind() with different argument conversion (__SC_CAST vs __SC_COMPAT_CAST)? I thought that was the whole point of the macros. Arnd