Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4624529pxv; Tue, 27 Jul 2021 11:59:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycrAADod6exCaSCnFquETqe7FmX7LktE2qyOhmh9x6nKemBaRM6NriDALHYhkvpEtqJ21Q X-Received: by 2002:a05:6e02:190e:: with SMTP id w14mr16991066ilu.61.1627412376532; Tue, 27 Jul 2021 11:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627412376; cv=none; d=google.com; s=arc-20160816; b=QqJejf5iXaHwNKisTX2zR8xRUDPeFeEeJOSTcw5U8v1wddfbSyKcCFMR6f/cgcv3uH Ys6+BH9GgbAYtin2UmatyhUpYGrp37iO1kCvhKT2/FmjKy8AyxaBArAFN23KTHntJVtV RVlgm5FYb+SZAIMfGODTfQghdcsCLLf74k4g3edmf/l8PK3T60I3kWN1O29Ok3Ud3zqz 3G72sHhFOVWM5+KsMmpK+0Er0IahuVH2NoG/3O7B+1TAZnF0g9Pe3dlraPPkDzWPhroy YivNq5fJYWsNbJ40pUH33s0cQ/dhNvkfr4/ox4Q7iR5l85mAzHOCtNdk6LBzjstVyhoq jQRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CQXN6JBdm9Q1P062FplZTT9i94VpM/Awhs7t6wRes/M=; b=dxwAS2rq+K1Nu9LfMnbaZep/eTPvuGOTtJNvXrGogkO+gy9UVs1kGn8NkJ+YByYXks 8bDBbAYUoUsmNbc6wUFYMRMyxU7EDLcRmx1zne5tSWPjIfCp3+OWahhfhKmWcOlKgMxL JWYgh905Oy1Trn7JpayUKz5e75uQwMdV7nOL26a9U7W07MWsA07HKEUZ5fI7wxPhr4jx KNQDaVVK34XuxdQ/2oULLq2d39nopgtjee8bIYMhuHlga462mwLwl8kij9ARETau8OO3 nSu+rhCA4wGyqssucUxqwk3oADSdvG1yZD/jGL5kWZM8inkfDAOkzprAU2MtjSTw1X93 jjpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="cDkwPv/K"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l6si3954462ilg.44.2021.07.27.11.59.24; Tue, 27 Jul 2021 11:59:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="cDkwPv/K"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231896AbhG0S6K (ORCPT + 99 others); Tue, 27 Jul 2021 14:58:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231844AbhG0S6J (ORCPT ); Tue, 27 Jul 2021 14:58:09 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02142C061760; Tue, 27 Jul 2021 11:58:09 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id h11so17174626ljo.12; Tue, 27 Jul 2021 11:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CQXN6JBdm9Q1P062FplZTT9i94VpM/Awhs7t6wRes/M=; b=cDkwPv/KS7gsBubTfTnzWlPHDXMLUwCVYEoIrK9mtmw2iBkVQeE80dB5Zuxo49V4B6 3Tmbq54vlV7ie2fMhjKTg/sKaAth0UBMYsKhjmPxfZc1MKIEa6/MncsJedvvjF80pE8l mTFQibi3bpgUHgZHyEyotCNCZqFIr+Jazbn7/1B/DdF42HyDtaoeR6zUIsSSYLM8uI4X rDJ6DLdHZH7x6DYCjnNM2CHp+kDbbdelOI0bkG8NNjRIlpfjJmtrowpV/pCUDzjbFs9n tjJlstG3zc9L3q4GSpx29KbO+bF9PLu/9HdHHcungAgMvseYcbexXSK4ZUJ61yiiTTCp JYLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CQXN6JBdm9Q1P062FplZTT9i94VpM/Awhs7t6wRes/M=; b=cSn+h1RkXPpPm/rwqt8Qc881HBHgoGXvuiKx64eCn1/gztHV/4qlGcitPG9JOXuVOn 1XabxwGc/4RcWg6QuPj1lCWvH2hVxgnOzVDkCqlFjQG9dRkyOcVt+tsGpq0iva4L2Utp XReRwnw1S3Ljw7VMleXtO1KBkC1sokrfwGAJEVdZ46oB5T2CyRs0gad9w158JRnCIhjy mVqx8myVD3TDl4lChXKE/BJCDEpfMlQYtq7zuIQqBZmVlEBXtTq8JQIsrfqVRh9BhlVm LgeM388C/kMlqVWvMVZfiAq0vHEs8vtVtea5vj+3fvsiZBevE06uiKL2mP4nKcpZpcm2 oL6Q== X-Gm-Message-State: AOAM532IhOyu6tbcILS86W7LOGcZRuVooIeAOJf4hReb84njpa8mY4Vy 3+ZLdMqUXlPNdBxBOicM904= X-Received: by 2002:a2e:545d:: with SMTP id y29mr16583219ljd.469.1627412287318; Tue, 27 Jul 2021 11:58:07 -0700 (PDT) Received: from localhost.localdomain (broadband-95-84-198-152.ip.moscow.rt.ru. [95.84.198.152]) by smtp.gmail.com with ESMTPSA id u9sm361768lfc.278.2021.07.27.11.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 11:58:06 -0700 (PDT) From: Maxim Devaev To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, sandeen@redhat.com, mdevaev@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration Date: Tue, 27 Jul 2021 21:58:00 +0300 Message-Id: <20210727185800.43796-1-mdevaev@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SET_IDLE value must be shifted 8 bits to the right to get duration. This confirmed by USBCV test. Signed-off-by: Maxim Devaev --- drivers/usb/gadget/function/f_hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index 8d50c8b12..bb476e121 100644 --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb/gadget/function/f_hid.c @@ -573,7 +573,7 @@ static int hidg_setup(struct usb_function *f, | HID_REQ_SET_IDLE): VDBG(cdev, "set_idle\n"); length = 0; - hidg->idle = value; + hidg->idle = value >> 8; goto respond; break; -- 2.32.0