Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH] arm64: tegra194: Fix Tegra194 PCIe EP compatible string
To:     Vidya Sagar <vidyas@nvidia.com>, <robh+dt@kernel.org>,
        <thierry.reding@gmail.com>
CC:     <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kthota@nvidia.com>,
        <mmaddireddy@nvidia.com>, <sagar.tv@gmail.com>
References: <20210727185055.11010-1-vidyas@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <23d08fdf-35e1-5af4-8992-17bc2f0ce7ef@nvidia.com>
Date:   Tue, 27 Jul 2021 20:05:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210727185055.11010-1-vidyas@nvidia.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2021 19:05:56.1365
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ba57bbdd-13b0-41bb-3b07-08d951319020
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT004.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB2527
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 27/07/2021 19:50, Vidya Sagar wrote:
> The initialization sequence performed by the generic platform driver
> pcie-designware-plat.c for a DWC based implementation doesn't work for
> Tegra194. Tegra194 has a different initialization sequence requirement
> which can only be satisfied by the Tegra194 specific platform driver
> pcie-tegra194.c. So, remove the generic compatible string "snps,dw-pcie-ep"
> from Tegra194's endpoint controller nodes.
> 
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra194.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> index 076d5efc4c3d..2f58f3e4746b 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> @@ -2098,7 +2098,7 @@
>  	};
>  
>  	pcie_ep@14160000 {
> -		compatible = "nvidia,tegra194-pcie-ep", "snps,dw-pcie-ep";
> +		compatible = "nvidia,tegra194-pcie-ep";
>  		power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX4A>;
>  		reg = <0x00 0x14160000 0x0 0x00020000>, /* appl registers (128K)      */
>  		      <0x00 0x36040000 0x0 0x00040000>, /* iATU_DMA reg space (256K)  */
> @@ -2130,7 +2130,7 @@
>  	};
>  
>  	pcie_ep@14180000 {
> -		compatible = "nvidia,tegra194-pcie-ep", "snps,dw-pcie-ep";
> +		compatible = "nvidia,tegra194-pcie-ep";
>  		power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>;
>  		reg = <0x00 0x14180000 0x0 0x00020000>, /* appl registers (128K)      */
>  		      <0x00 0x38040000 0x0 0x00040000>, /* iATU_DMA reg space (256K)  */
> @@ -2162,7 +2162,7 @@
>  	};
>  
>  	pcie_ep@141a0000 {
> -		compatible = "nvidia,tegra194-pcie-ep", "snps,dw-pcie-ep";
> +		compatible = "nvidia,tegra194-pcie-ep";
>  		power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>;
>  		reg = <0x00 0x141a0000 0x0 0x00020000>, /* appl registers (128K)      */
>  		      <0x00 0x3a040000 0x0 0x00040000>, /* iATU_DMA reg space (256K)  */
> 


Thanks! We should also push a patch to remove this compatible string
from the example in
Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt. For this
one ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Cheers!
Jon

-- 
nvpublic