Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1627306847-25308-3-git-send-email-rajpat@codeaurora.org>
References: <1627306847-25308-1-git-send-email-rajpat@codeaurora.org> <1627306847-25308-3-git-send-email-rajpat@codeaurora.org>
Subject: Re: [PATCH V4 2/4] arm64: dts: sc7280: Add QUPv3 wrapper_0 nodes
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, rnayak@codeaurora.org,
        saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com,
        skakit@codeaurora.org, Roja Rani Yarubandi <rojay@codeaurora.org>,
        Rajesh Patil <rajpat@codeaurora.org>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rajesh Patil <rajpat@codeaurora.org>,
        Rob Herring <robh+dt@kernel.org>
Date:   Tue, 27 Jul 2021 12:20:30 -0700
Message-ID: <162741363048.2368309.1689681966672627944@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Rajesh Patil (2021-07-26 06:40:45)
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/q=
com/sc7280.dtsi
> index ca6e36b..455e58f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -520,6 +520,25 @@
> =20
>                 };
> =20
> +               qup_opp_table: qup-opp-table {

Surely this can live underneath a qup node parallel to the i2c and spi
devices?

> +                       compatible =3D "operating-points-v2";
> +
> +                       opp-75000000 {
> +                               opp-hz =3D /bits/ 64 <75000000>;
> +                               required-opps =3D <&rpmhpd_opp_low_svs>;
> +                       };
> +
> +                       opp-100000000 {
> +                               opp-hz =3D /bits/ 64 <100000000>;
> +                               required-opps =3D <&rpmhpd_opp_svs>;
> +                       };
> +
> +                       opp-128000000 {
> +                               opp-hz =3D /bits/ 64 <128000000>;
> +                               required-opps =3D <&rpmhpd_opp_nom>;
> +                       };
> +               };
> +
>                 qupv3_id_0: geniqup@9c0000 {
>                         compatible =3D "qcom,geni-se-qup";
>                         reg =3D <0 0x009c0000 0 0x2000>;