Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4658515pxv; Tue, 27 Jul 2021 12:56:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgGH7l5qzoRkIZwA6SDCgoz7plJNQhwBcsf/Pf/9LkM8ITixCgFTuX69CJuDwc7Uh+RUOn X-Received: by 2002:a02:a1c8:: with SMTP id o8mr22538325jah.50.1627415766883; Tue, 27 Jul 2021 12:56:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627415766; cv=none; d=google.com; s=arc-20160816; b=QlTfGz9+87GAJ8GB3C3wT/3NaPS/nHBIec6Ie9vG5RRSiYwcsOKQz6uv2+HkawLS4m Z7UuZK05AqfkGZu3m73QeB0nXgD4aOcB73PkPIi69iOnmw/mfFWqk5LxeMDnb45PUDa2 Ru59SYuf7aEZY0es345pCVEFI39bdMk0Lm1aDH2kuFFFeY3WAz1+ypDmadmCK8l6ebQO Z7HLSafGIm4B5VzzkNeUZBMG2btArlxjhS8RMimjecbzZeHU+G63EGsR6MZqXCIwMyym EhuusSp501oaB4NHAjUoRGqzKW9G4LERWXncqOqAywKeLRLENEVRRXF0zGeu2OhF9zFR 6AFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=84cVMNpD6JInshyif5EXE/6WAAmYU32gfGfEV/lbJyg=; b=oQ9+lIDo5aMqddnoasZxHxyFKP/MOaz5PK/gB51YLdmiqAbSSLg/LpY5f53j4opPEZ PQTaCk7uOrJmepHBlcJJPG9A3sBZvnqRAJ95Xhwl/ft9nAMv7+uxSEaZlz5Vrw0GQQpL pirTLStdJUsfgv3HpngdAQpBabT4nBXEyKByf/yR4+J+ol8dSaq0cm40szhDhRG6utNH YdcOFDPPiFG4cjNbaID3ekJRhaV1IDDblx6Wmwro/W8hY2cOJPpnPCVLcN4VsAKUKlL+ 5axKRw3qexiLCuzjhlDuGgV0/e8CPylUibhtRRRXKEQijjPmiHYVwqZwXq/OpQr7xykP PGnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v18si4081816ilo.15.2021.07.27.12.55.53; Tue, 27 Jul 2021 12:56:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230484AbhG0TzH (ORCPT + 99 others); Tue, 27 Jul 2021 15:55:07 -0400 Received: from mail.netfilter.org ([217.70.188.207]:36048 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbhG0TzG (ORCPT ); Tue, 27 Jul 2021 15:55:06 -0400 Received: from netfilter.org (bl11-146-165.dsl.telepac.pt [85.244.146.165]) by mail.netfilter.org (Postfix) with ESMTPSA id 794496411D; Tue, 27 Jul 2021 21:54:34 +0200 (CEST) Date: Tue, 27 Jul 2021 21:54:59 +0200 From: Pablo Neira Ayuso To: Kyle Bowman Cc: kernel-team@cloudflare.com, Alex Forster , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] netfilter: xt_NFLOG: allow 128 character log prefixes Message-ID: <20210727195459.GA15181@salvia> References: <20210727190001.914-1-kbowman@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210727190001.914-1-kbowman@cloudflare.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Jul 27, 2021 at 02:00:00PM -0500, Kyle Bowman wrote: > From: Alex Forster > > nftables defines NF_LOG_PREFIXLEN as 128 characters, while iptables > limits the NFLOG prefix to 64 characters. In order to eventually make > the two consistent [...] Why do you need to make the two consistent? iptables NFLOG prefix length is a subset of nftables log action, this is sufficient for the iptables-nft layer. I might be missing the use-case on your side, could you please elaborate?