Date: Fri, 24 Nov 2006 11:41:56 +0000
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Juergen Beisert <juergen127@kreuzholzen.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 001/001] i386/pci: fix nibble permutation and add Cyrix
 5530 IRQ router
Message-ID: <20061124114156.1b02cf2e@localhost.localdomain>
In-Reply-To: <200611241144.06267.juergen127@kreuzholzen.de>
References: <200611241144.06267.juergen127@kreuzholzen.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1044
Lines: 24

On Fri, 24 Nov 2006 11:44:05 +0100
> Cyrix 5520 and Cyrix 5530 do interrupt routing in the same way. But the
> (pirq-1)^1 expression to set a route always sets the wrong nibble, so
> INTA/INTB and INTC/INTD are permuted and do not work as expected.
> 
> Signed-off-by: Juergen Beisert <juergen.beisert@weihenstephan.org>

NAK

This will then break other boards. As far as I can tell there is no
"correct" answer here for 5530 based hardware. The existing setup makes
most random CS5520/30 based PC systems like the Palmax laptops work if the
irq router is used, your change will break them

Given the choice between LinuxBIOS and the rest of the world then the
rest of the world needs to win. The 5530 is absent from the IRQ routing
table because it varied by system what the right answer was.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/