Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210708141935.bx33mv2jxtm752z3@julianexternal> <20210714075723.17294-1-jose.exposito89@gmail.com>
In-Reply-To: <20210714075723.17294-1-jose.exposito89@gmail.com>
From:   Alex Henrie <alexhenrie24@gmail.com>
Date:   Tue, 27 Jul 2021 15:58:59 -0600
Message-ID: <CAMMLpeTKcd+WijyEAnH9vkHjuF+_K9-_EvTXThCDOhoeucNyHg@mail.gmail.com>
Subject: Re: BUG: cannot enable iso_layout with apple keyboard
To:     =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Cc:     juw@posteo.de, Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Jiri Kosina <jikos@kernel.org>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 14, 2021 at 1:57 AM Jos=C3=A9 Exp=C3=B3sito <jose.exposito89@gm=
ail.com> wrote:
>
> > Hi,
> >
> > I have an apple keyboard model A1644 EMC 2815 with Finnish/Swedish ISO =
layout. When I connect it via
> > cable it works fine. But when I connect it via bluetooth, then the butt=
ons >/< and =C2=A7/=C2=B0 are swapped.
> > It seems to make no difference if I set iso_layout to 0 or to 1. I chec=
ked and it turns out that
> > hid->country below equals 0, and removing the check
> >
> > diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> > index 6b8f0d004d34..8a764ce4e518 100644
> > --- a/drivers/hid/hid-apple.c
> > +++ b/drivers/hid/hid-apple.c
> > @@ -267,13 +267,11 @@ static int hidinput_apple_event(struct hid_device=
 *hid, struct input_dev *input,
> >         }
> >
> >         if (iso_layout) {
> > -               if (hid->country =3D=3D HID_COUNTRY_INTERNATIONAL_ISO) =
{
> >                         trans =3D apple_find_translation(apple_iso_keyb=
oard, usage->code);
> >                         if (trans) {
> >                                 input_event(input, usage->type, trans->=
to, value);
> >                                 return 1;
> >                         }
> > -               }
> >         }
> >
> >         if (swap_opt_cmd) {
> >
> > makes the buttons act correctly. Please let me know how I can help fixi=
ng this.
> >
> > Best regards,
> > Julian Weigt
>
> Hi Julian,
>
> I can confirm I can reproduce the issue with a Spanish/Spain keyboard.
>
> The problem seems to be that the field "bCountryCode" is not present when=
 the keyboard is connected over bluetooth.
>
> CCing Alex Henrie, hopefully he can add useful information about the issu=
e.
>
> Best wishes,
> Jose

Thanks Julian and Jos=C3=A9 for bringing this to my attention. I also found
an Ubuntu bug report [1] which suggests that some of Apple's USB ISO
keyboards do not set the country code either. I have ordered a variety
of Apple keyboards from eBay for testing and I will send a fix as soon
as I am able.

-Alex

[1] https://bugs.launchpad.net/ubuntu/+source/xkeyboard-config/+bug/1886215