Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4751451pxv; Tue, 27 Jul 2021 15:46:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtOTqzeoN6F0XBBlOcejFNv4+h6Fu+Of4PWOFF+tOY2BJAIh5s4hxmctmqG5X5O8fX9duE X-Received: by 2002:a92:d3d2:: with SMTP id c18mr18225425ilh.192.1627425959896; Tue, 27 Jul 2021 15:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627425959; cv=none; d=google.com; s=arc-20160816; b=JQlpCBbXvZgjIGz0DX2Zc3VZSm0RM7tAbFVULW31wf1OcgZS9MoXAw43ievF1n8NkQ uf5A9pB+LursRvlx9vij/FtdtVm86i5m2QINehBc457/+DI3b4cKSoAvADb+ErEOs59M LPGqjN8jGAYOD7/GthHUFCvYwby6n6pBfpj1DNMjHXb1GZRG92cC3Ria6dRdye6iWWAW V9uYCI0j/+FgT6SEh+QCt4TYqg5xM3T1HHBKG2njHA2pX3qb86fLWo1w0WPWW2wrm3jq I71tj6LMf1LZWMeQsXHl7eUvm/rRxv2v787T4iAe6RZj7Jaok279r3TYP3ge05XnijzK f1xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=F2VzMT246wGHVuc/C9Yr3QO5HUyDdP84+0q/UDf2X6g=; b=pXXwJrxdnEgWF5YF2xi92D3/zHq4wsICrZFBGfri6+eYoX9BfQM1v1jb4ne0aZxPkL opWf6dqv7v2Srv5ntzF7W1VLgR5aMmr37HDureEmgTETFrUSC7QdZTcW7uvoHnYz7VPM Y5+52Ltl5+z506GiC4pwUInKBchznE679ARTP7mLKXEiaGzKMp8sEx6HNQbkVx2OtLQQ gSKVStDqnH7oLCFGvQ/JrHLxl2bawgRlFyVr+y30emG8FnrOvqhTit4RD9HO8xkTEkGM fBad+fx9eusOvQWmDFHLroCZFJISm7ggpm08VuaQxNG75P/4sB4L0LVWzCQAwltwVd7D m9lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="PwMkTFH/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si4585125ilg.116.2021.07.27.15.45.48; Tue, 27 Jul 2021 15:45:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="PwMkTFH/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232576AbhG0WpI (ORCPT + 99 others); Tue, 27 Jul 2021 18:45:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232336AbhG0WpI (ORCPT ); Tue, 27 Jul 2021 18:45:08 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04E49C061757 for ; Tue, 27 Jul 2021 15:45:07 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id ds11-20020a17090b08cbb0290172f971883bso7053834pjb.1 for ; Tue, 27 Jul 2021 15:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=F2VzMT246wGHVuc/C9Yr3QO5HUyDdP84+0q/UDf2X6g=; b=PwMkTFH/H7ItHM5Ni1u4MMEdqyaBLO3/VCima4M0PnAJqoTXJkRnqf6kAoBsGyb4He CH+fDf5FHRa1L7Lvsgyi55s00bbJGF+1nNsmYyw3kRz+7EodZ/BrJZ170fbhB3YYXplM dUyuKmzDp7/lQP8hLTbBeaZB93HGv/yXHBdckuVS/55YrydpcymOulVx9NCuTaP9G8Tn i/pTPmxsEIIcQ3xwtrCTEK3XvwMKXiOXXpkMFneL3ON90V0YJPQCM4O34sWDL+AZPAdn K4RXRaoxejlfTO+5nZEidGO5gs3m8TorFdA9hXkY3M1SxBQJvkgOc6sLawTavyxwegEI u2jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F2VzMT246wGHVuc/C9Yr3QO5HUyDdP84+0q/UDf2X6g=; b=dx51TAFEnqpVpFLaUR3Dx6ZEXaOQCawh8+4mH98zhksc4uG/eUCy+y2Llbv6RnS9Ez 3bjcflXaTwobkYb6y38RngIwdRh6iydzp9yQoApK/Etqn2RbFpUAVrEV9+bHzG7zF1U/ yZ4zvno7tKnbVK3qeGYbunaHBUnT5ncGhvFmX4i+GlTr/lqE5TJ8SdNHO6dlL9ksHBzJ woMPe1yACIIBOHXHOmpLjkNXRSoGdCp0ToC4tpj2703ni6bec2uiqTOhYKp6HdI/FofU nSwcscWFXOc3S1aJ6WrVPJ1M5+UtYv9vhYbwEJssxuzV21kRfO4a9mE0WOXIfxlzTKgy qOfg== X-Gm-Message-State: AOAM533u29sX/cGJJmoNX6QotdlKxuYObStf267YtZ4GvWI4eJjYzJh2 cNPaIW+C9/t30+gU+Fpw1N6X1g== X-Received: by 2002:a17:902:fe87:b029:12a:ef40:57a2 with SMTP id x7-20020a170902fe87b029012aef4057a2mr20597385plm.81.1627425906358; Tue, 27 Jul 2021 15:45:06 -0700 (PDT) Received: from [192.168.1.116] ([198.8.77.61]) by smtp.gmail.com with ESMTPSA id f4sm5288861pgi.68.2021.07.27.15.45.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 15:45:05 -0700 (PDT) Subject: Re: [PATCH] blk-mq-sched: Fix blk_mq_sched_alloc_tags() error handling To: John Garry Cc: osandov@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ming.lei@redhat.com References: <1627378373-148090-1-git-send-email-john.garry@huawei.com> From: Jens Axboe Message-ID: <20fb9978-af00-0bc6-33d2-c41bfb129cb4@kernel.dk> Date: Tue, 27 Jul 2021 16:44:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1627378373-148090-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/21 3:32 AM, John Garry wrote: > If the blk_mq_sched_alloc_tags() -> blk_mq_alloc_rqs() call fails, then we > call blk_mq_sched_free_tags() -> blk_mq_free_rqs(). > > It is incorrect to do so, as any rqs would have already been freed in the > blk_mq_alloc_rqs() call. > > Fix by calling blk_mq_free_rq_map() only directly. Applied, thanks. -- Jens Axboe