Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/3] hugetlb: fix potential ref counting races
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Michal Hocko <mhocko@suse.com>,
        Oscar Salvador <osalvador@suse.de>,
        David Hildenbrand <david@redhat.com>,
        Matthew Wilcox <willy@infradead.org>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        Mina Almasry <almasrymina@google.com>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20210710002441.167759-1-mike.kravetz@oracle.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
Message-ID: <22abb0f0-ce85-3567-3bfd-74dd1450c14f@oracle.com>
Date:   Tue, 27 Jul 2021 16:41:51 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
In-Reply-To: <20210710002441.167759-1-mike.kravetz@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.2.123] (50.38.35.18) by MWHPR2001CA0004.namprd20.prod.outlook.com (2603:10b6:301:15::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Tue, 27 Jul 2021 23:41:53 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: febac2c9-77d7-4664-5f48-08d951581d36
X-MS-TrafficTypeDiagnostic: BYAPR10MB3591:
X-Microsoft-Antispam-PRVS: <BYAPR10MB359182634B3B549F4FC9EBBAE2E99@BYAPR10MB3591.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PblOZDrW1D2xWAzrxAte7qb5mUyK/p9dhZc2VFpPbeIZMfM3vAx32qP3CWfOufMQEPWrVUXJUq9OQznBA71gaWnXZ6yyL6adG/Mq5jHQ5MJq35pLXbNr80Th+Ownzgt1Ab5WDJcRTIB3I71hcMCK313ZyV2OlOjTlcsExiC4QqYB1DZ2NCkmHFNK2nuNw9Sq6sWqt4rMujM57Z9523p7c47Rq/A+cnqYhDj0CJnTYQjyjkLhg4TjA0bH8j0asRrvbn/FXT94mkvp6mxv1GRu5GJMbHdVfnzoBcbfoVGDYM4H8AlZCWEre12YFKg5Af0brFJPctY2KzWnKaduCqBPd+j99laS8dhudSZFNO+3rVQcF1kNMn6YpMYem7ujbfh2VaRLPXA1pSaGnuQ8sUZA/Y/YIkmAtZbcpAM9YtFXFo7OsXRRDIYg+cdg1XQU25an3f29jOayM1T8V+QwGd4ejO73S3zrQF22qgAxksa022BxbU5mQEjS02AMY+q3iosPWPNbrKsfSZLGSEtf6y0xSk2VsTdNnTP8LP+DwwtRKpLMvL83BX/rl4YNL659/Ldbvuog4SWmpIKHG5Jl7oP1QEpo2puh+TvlGzGeUe6oeb9TvI490f4mL6uzYEeqcxMrSsYI/vgoBn+ahFU4MPlZYxvCbuyPspo376HLUzZqWnD2DWarwV5djYBQ1jw/lMdA9GoiHpOw7ftcfwa5fSbS2PU19LbIHMVtAEMpAvD/GLnyp/Mneyeqy6cNr7+Mj3J+l9np2sXSV7QMsISkilWt3ZANXrfh2Yqoqbv/au4GzHrlxZGa5aXiXluISM26NJdYzKdFoJ6jL7HStupeGxXN8D3pBNL+V8A11GWlYeC+3XA=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(396003)(346002)(366004)(136003)(186003)(2616005)(956004)(66946007)(66476007)(38100700002)(316002)(7416002)(38350700002)(6486002)(478600001)(16576012)(26005)(52116002)(53546011)(2906002)(966005)(44832011)(66556008)(54906003)(5660300002)(86362001)(31686004)(8936002)(31696002)(8676002)(83380400001)(4326008)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEV5RURjMjkyMTZCOHM0S1FLSlhvenNzcWlCL09vS3JodjU2SCtQVW14LzVX?=
 =?utf-8?B?NHBFR2U4VEVZZHB0WnM0UG1ac1dTM3cwdmNTeEtzN2gwRExXaWo3NFBpUGZa?=
 =?utf-8?B?VEI2ak1kSEdXdW9kVWM1RTNETXJVQkVJWDg2cUYxV1NsSFpiMXFMWlZmZFJB?=
 =?utf-8?B?SldDdm1LMEhYMWR2S3JvU3FBSmFHTEdXLzhic2tFZ2xxMGxjaVVuR2F6UlFh?=
 =?utf-8?B?MTdweXlZWmVpYlpjMjVUV25tVmc2YVEyNE44MjFDTWk5WU9FVjk3NXVrZ1lZ?=
 =?utf-8?B?ZEx4NmthVkVuL2tJeWpwZ2tzdUQzYmZNMlEzc05qWURFQW1uSFFaY0xDZlc0?=
 =?utf-8?B?M0dDbitEeHVHQUh3djZrMGpESkhuYWpQSUUrRTV0OXRFOFE2a1hUUnhaRzgx?=
 =?utf-8?B?MG9LNmtlNG12NGxkOTVZdjdvZjZvcU5FalZhcytnZkw3NzNkL3V4NGROaUVB?=
 =?utf-8?B?MG1EaVRWbDRzWHgrR2RzUGxwU08wSmlINnVYYnRiWk5aV1F4YUlBZ1dDNUxk?=
 =?utf-8?B?M0dEdElPUFEzSzdKc1d1TGYvWFNLWVlGbk1Yc2M2OEREeXYzdmlwcCt4S0lD?=
 =?utf-8?B?bFJWWDc5Zmg1QnRqRm4zU3JFTmpML25oVjA4QW5naFlXUk5pbW9jakFibkQy?=
 =?utf-8?B?cE5YVU94SURSam1HaVRLcU1IWmVQTXd0cTVjcFZyTHhlTWltaktVaXZKVWNj?=
 =?utf-8?B?QzJPS3EyVTByS0xWY0Vsa05FdExtbnhFbXlHVXJpMDFlN0NDSmRyZE9kb25T?=
 =?utf-8?B?WnZZT1lNM1NnY3d2bERKaUI0anpNMEkwQVRQNmpTakVTUlQrd2ZxS0NteThO?=
 =?utf-8?B?czFnS1haOWZsaDNXR1JUenZqUTBvNG9LQUd6SFFKczMrUVB0T3JpSjJJRWxV?=
 =?utf-8?B?OG1nTGs5TzFsQWkrZXdzaEhlV2VlTHZzMEdZTEwrRFphS1RHVEQrSU51bVU4?=
 =?utf-8?B?Z3JVQm5UcjBaTGNsNHJJRDZUU0JtMFlJRi9RenpKcEFZQnQrSUY2bWVYbmJp?=
 =?utf-8?B?MGdaVHpaMlRoZXFiZkpOelZQbjNjVnNoUnBhNE96Zkc4K1IycTBaOGRhTGJx?=
 =?utf-8?B?UzFyK2lhWkg1SCsvUjNyRndzdXFWaHZpRGowcFF4SkFSS3JJYWRBYnV6Y3I4?=
 =?utf-8?B?R3N0U2dnSnVqc3p2Zk53ZHVrMUMxU1A0aHp3TFJ6NUNvUWxSUTR6N0JJU2Nx?=
 =?utf-8?B?aGI1MDZOL2o5Q3pjekpYRDJTR2M3dlExWTBRMU9yUUVXTTFOVFV6emtjZmNH?=
 =?utf-8?B?T0xDMU11emQvVUxQcjY0N0FzL3NnZVZxYUZGMjQ0bWJXTjNsVDNPNDVKeDEz?=
 =?utf-8?B?L1llS21sVWt4UGhWWVRUMnQ0SkhvSTVuWGlMUjFEb0p0SGNNczloV2pJMTdV?=
 =?utf-8?B?VHVEeE5JZ091ZkVRMElQTkRPRDdwYlFKRGROcU1wUHFGMU9SdGJkaGNqandj?=
 =?utf-8?B?L1laNFR4cTRXdG85QVB3RHd1ZzlmTjJGSksvZFhqQktJc2V4YURaMko5dHVx?=
 =?utf-8?B?ZFh4UFpDTzdwTC9Vbk5jUXJVOEx5TUh6cGRqNHFDSFB1ZHl2NWwvM2Q1b2VQ?=
 =?utf-8?B?dXRQLysrVmVwSERESXNlNlZpZTVhTWRhc0xCdEJlamc2eUtmYlR4T3lVeXl6?=
 =?utf-8?B?bm5rZmM5R01ZeWh3UmwvNytGWkgrSVg1K2lMU3NPTExnMml0SWcrclBRMHJ4?=
 =?utf-8?B?Q1NGQTN0VjYxK01hV2FybkgzVDVVYlIyb2tmcElhMWVqVHkrQi8ySkhNYU1D?=
 =?utf-8?Q?INLtG9QoanAluwwa2tyf9fSCNcmIyIMrDPrQPRW?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: febac2c9-77d7-4664-5f48-08d951581d36
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2021 23:41:54.0711
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6os7bC+m5j+sxWA/1JBVeKCIxvvKKLjFlj0YnK2hbhEISzw//00JOWUk7d6C67ZKwuqXONvZFGLol/cvAgKJ5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3591
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10058 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0
 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2107270134
X-Proofpoint-ORIG-GUID: hvruIxiQOHyG1EWp2_Rvs1KVddQ9pXiv
X-Proofpoint-GUID: hvruIxiQOHyG1EWp2_Rvs1KVddQ9pXiv
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Any additional comments on these patches/this approach?

The first patch addressing this issue actually went into the 5.14 merge
window as commit 7118fc2906e2 ("hugetlb: address ref count racing in
prep_compound_gigantic_page").

All this code is very tricky and subtle.  It addresses potential issues
discovered by code analysis.  I do not believe the races have ever been
experienced in practice.  If anyone has suggestions for a simpler or
alternative approach, I would love to hear them.
-- 
Mike Kravetz


On 7/9/21 5:24 PM, Mike Kravetz wrote:
> When Muchun Song brought up a potential issue with hugetlb ref counting[1],
> I started looking closer at the code.  hugetlbfs is the only code with it's
> own specialized compound page destructor and taking special action when ref
> counts drop to zero.  Potential races happen in this unique handling of ref
> counts.  The following patches address these races when creating and
> destroying hugetlb pages.
> 
> These potential races have likely existed since the creation of
> hugetlbfs.  They certainly have been around for more than 10 years.
> However, I am unaware of anyone actually hitting these races.  It is
> VERY unlikely than anyone will actually hit these races, but they do
> exist.
> 
> I could not think of an easy (or difficult) way to force these races.
> Therefore, testing consisted of adding code to randomly increase ref
> counts in strategic places.  In this way, I was able to exercise all the
> race handling code paths.
> 
> [1] https://lore.kernel.org/linux-mm/CAMZfGtVMn3daKrJwZMaVOGOaJU+B4dS--x_oPmGQMD=c=QNGEg@mail.gmail.com/
> 
> Mike Kravetz (3):
>   hugetlb: simplify prep_compound_gigantic_page ref count racing code
>   hugetlb: drop ref count earlier after page allocation
>   hugetlb: before freeing hugetlb page set dtor to appropriate value
> 
>  mm/hugetlb.c | 137 ++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 104 insertions(+), 33 deletions(-)
>