Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 27 Jul 2021 20:21:48 -0400
Message-Id: <CD4CE5OQT5TJ.2BFPBRYK7FCOW@shaak>
To:     "Peter Rosin" <peda@axentia.se>, <jic23@kernel.org>,
        <lars@metafoo.de>, <pmeerw@pmeerw.net>
Cc:     <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH v6 05/13] iio: afe: rescale: add INT_PLUS_{MICRO,NANO}
 support
From:   "Liam Beguin" <liambeguin@gmail.com>
References: <20210721030613.3105327-1-liambeguin@gmail.com>
 <20210721030613.3105327-6-liambeguin@gmail.com>
 <c9d77dc0-7f4c-0df0-cce1-8cb30074e115@axentia.se>
In-Reply-To: <c9d77dc0-7f4c-0df0-cce1-8cb30074e115@axentia.se>
Precedence: bulk

On Fri Jul 23, 2021 at 5:16 PM EDT, Peter Rosin wrote:
> On 2021-07-21 05:06, Liam Beguin wrote:
> > From: Liam Beguin <lvb@xiphos.com>
> >=20
> > Some ADCs use IIO_VAL_INT_PLUS_{NANO,MICRO} scale types.
> > Add support for these to allow using the iio-rescaler with them.
> >=20
> > Signed-off-by: Liam Beguin <lvb@xiphos.com>
> > ---
> >  drivers/iio/afe/iio-rescale.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >=20
> > diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescal=
e.c
> > index d0669fd8eac5..2b73047365cc 100644
> > --- a/drivers/iio/afe/iio-rescale.c
> > +++ b/drivers/iio/afe/iio-rescale.c
> > @@ -41,6 +41,20 @@ int rescale_process_scale(struct rescale *rescale, i=
nt scale_type,
> >  		do_div(tmp, 1000000000LL);
> >  		*val =3D tmp;
> >  		return scale_type;
> > +	case IIO_VAL_INT_PLUS_NANO:
> > +		tmp =3D ((s64)*val * 1000000000LL + *val2) * rescale->numerator;
> > +		tmp =3D div_s64(tmp, rescale->denominator);
> > +
> > +		*val =3D div_s64(tmp, 1000000000LL);
> > +		*val2 =3D tmp - *val * 1000000000LL;
> > +		return scale_type;

Hi Peter,

>
> Hi!
>
> My objection from v5 still stands. Did you forget or did you simply send
> the
> wrong patch?

Apologies, again I didn't mean to make it seem like I ignored your comments=
.
I tried your suggestion, but had issues when *val2 would overflow into
the integer part.
Even though what I has was more prone to integer overflow with the first
multiplication, I thought it was still a valid solution as it passed the
tests.

>
> Untested suggestion, this time handling negative values and
> canonicalizing any
> overflow from the fraction calculation.
>
> neg =3D *val < 0 || *val2 < 0;
> tmp =3D (s64)abs(*val) * rescale->numerator;
> rem =3D do_div(tmp, rescale->denominator);
> *val =3D tmp;
> tmp =3D rem * 1000000000LL + (s64)abs(*val2) * rescale->numerator;
> do_div(tmp, rescale->denominator);
> *val2 =3D do_div(tmp, 1000000000LL);
> *val +=3D tmp;
> if (neg) {
> if (*val < 0)
> *val =3D -*val;
> else
> *val2 =3D -*val;

I'll look into this suggestion.

> }
>
> > +	case IIO_VAL_INT_PLUS_MICRO:
> > +		tmp =3D ((s64)*val * 1000000LL + *val2) * rescale->numerator;
> > +		tmp =3D div_s64(tmp, rescale->denominator);
> > +
> > +		*val =3D div_s64(tmp, 1000000);
>
> Why do you not have the LL suffix here?

Doesnt' LL make it into a 64 bit integer?
I left it out because the second parameter of div_s64() should be s32.

Thanks,
Liam

>
> Cheers,
> Peter
>
> > +		*val2 =3D tmp - *val * 1000000;
> > +		return scale_type;
> >  	default:
> >  		return -EOPNOTSUPP;
> >  	}
> >=20