Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4816526pxv; Tue, 27 Jul 2021 17:52:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydvMKcRcF+jfmJ+xyBv8ZjSJFa9JjIXaAV3stqaDyHFHPd432vL0w7qnhIEj2MvA6Hr+jP X-Received: by 2002:a17:907:7d9f:: with SMTP id oz31mr24010727ejc.366.1627433537380; Tue, 27 Jul 2021 17:52:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627433537; cv=none; d=google.com; s=arc-20160816; b=tUeyxKXfPDyN48AsV/GovAo45us9Dk7z0n8YZXaQ2d4ghKBAPGdCOD42Cz1uX86Trz UX/QVImd7G8T5K3jdM0FNJQ7nZ6ALJts/82u3yaOsm1rLJxrMAhbhRBCJ0jvwxqNcc7y 0LB3yorx+67Z/M5/b+nArL/nTgF7tPebn9Qo3l8crZOiSwa7ug74zUgVda2O/B1+Zm53 UThpXsfGlZUxCQU0MxaiwqfKMDO9y6Du6EoLovfUUCe+jEIIMpZqsp3lHkNkuMrT0/Ma Ggun9N3xa6s/rucoR5fszLo/W61uXIdwH5W4MktlTISjBlmYDsVOApshWjo+rgBUzFB0 0Z7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=vprmzsxQqzKlgMuVqNDGJ0J6pDeEfKeibaCSg8qYOPI=; b=pFSx1GgRkNCDS2GhWEXhOt9HU3c+QbqIdppPu2nc6OLrT4cMf+sF1te25aPA3Qu/h3 iQM/cxJpcneUD5T3Ip8S0AiqvuSUnNHgqCzbDgyP6tUUzkheMW+ZRRAlHbY3nH8Y2uE8 0Vj0FZRPXrcdF7+A4khiQMJ9CprnZoqC4I18F10KXvxQIrlSK7H3EMJohcaP5lsNl9SJ H+Hb0cjBP5Zgml9tJ8vSw6Oztwf6V/wT84nZNev+HAp1GANFznJ+zJvXWbCa8bCHgwTv d25jhT1XYhs58EV/bi8fUJELtjN5VotBc+TLGz3vrS9YRjzlj7hyeO7XAni93q88yGe/ u83Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GKe+BWN8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l25si2069230eds.541.2021.07.27.17.51.47; Tue, 27 Jul 2021 17:52:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GKe+BWN8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232996AbhG1AuR (ORCPT + 99 others); Tue, 27 Jul 2021 20:50:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:36058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232883AbhG1AuR (ORCPT ); Tue, 27 Jul 2021 20:50:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 929C460F59; Wed, 28 Jul 2021 00:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627433416; bh=RA8Bk6N54tMlSb0oE/9C00ZcPcgPOkz1/lYJvfEXgDo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GKe+BWN8/HcuddopT5zDv48wJR6dpfcvMfz6bEJijTGoIyNSHxhvJtAB3l4HKbjRc O0PzS4S1llKqkERz2HA1Rgd5GG35jJZtKdBMnKeyB8yFry0eMOyZzq9ul6H95aYIuo caBxndDKMYH2EtmIgpjn2EUgFdLy9WeM5G5DdPDKvbV80KROTBOjJvtGKVFkQmNgCe FrQfHVMcYr+VgU9PabbroSemWXlnbwOGP0jJSBtCnlVebc/U7rbdqXWAMBAoUN5j93 VusEKf19MFGOuLxo0uHLck1alAOouXuRyLz1jPJQh/FkLoUVxnYHa0ZRSS7v7U5UYT Xh3oyw8qSqTwg== Received: by mail-lj1-f175.google.com with SMTP id a7so951421ljq.11; Tue, 27 Jul 2021 17:50:16 -0700 (PDT) X-Gm-Message-State: AOAM5318D6bSC9SL4I72hta3kbcmwD3V+WcwdCGslgiSL5ebg9eVV6gw t/Lh1cYoG8VDmxBJQBITErezklEW67Ub8n4oo9w= X-Received: by 2002:a2e:8557:: with SMTP id u23mr17307440ljj.115.1627433414969; Tue, 27 Jul 2021 17:50:14 -0700 (PDT) MIME-Version: 1.0 References: <20210727133426.2919710-1-punitagrawal@gmail.com> <20210727133426.2919710-5-punitagrawal@gmail.com> In-Reply-To: <20210727133426.2919710-5-punitagrawal@gmail.com> From: Guo Ren Date: Wed, 28 Jul 2021 08:50:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/5] csky: ftrace: Drop duplicate implementation of arch_check_ftrace_location() To: Punit Agrawal Cc: Masami Hiramatsu , "Naveen N . Rao" , Anil S Keshavamurthy , David Miller , Linux Kernel Mailing List , linux-csky@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked, thx. On Tue, Jul 27, 2021 at 9:35 PM Punit Agrawal wrote: > > The csky specific arch_check_ftrace_location() shadows a weak > implementation of the function in core code that offers the same > functionality but with additional error checking. > > Drop the architecture specific function as a step towards further > cleanup in core code. > > Signed-off-by: Punit Agrawal > Acked-by: Guo Ren > Acked-by: Masami Hiramatsu > --- > arch/csky/kernel/probes/ftrace.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/csky/kernel/probes/ftrace.c b/arch/csky/kernel/probes/ftrace.c > index ef2bb9bd9605..b388228abbf2 100644 > --- a/arch/csky/kernel/probes/ftrace.c > +++ b/arch/csky/kernel/probes/ftrace.c > @@ -2,13 +2,6 @@ > > #include > > -int arch_check_ftrace_location(struct kprobe *p) > -{ > - if (ftrace_location((unsigned long)p->addr)) > - p->flags |= KPROBE_FLAG_FTRACE; > - return 0; > -} > - > /* Ftrace callback handler for kprobes -- called under preepmt disabled */ > void kprobe_ftrace_handler(unsigned long ip, unsigned long parent_ip, > struct ftrace_ops *ops, struct ftrace_regs *fregs) > -- > 2.30.2 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/