Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934487AbWKXPLq (ORCPT ); Fri, 24 Nov 2006 10:11:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757787AbWKXPLp (ORCPT ); Fri, 24 Nov 2006 10:11:45 -0500 Received: from phoenix.bawue.net ([193.7.176.60]:20183 "EHLO mail.bawue.net") by vger.kernel.org with ESMTP id S1757616AbWKXPLp (ORCPT ); Fri, 24 Nov 2006 10:11:45 -0500 Date: Fri, 24 Nov 2006 15:12:05 +0000 To: "Maciej W. Rozycki" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH 2.6.18] dz: Fixes to make it work Message-ID: <20061124151205.GA927@networkno.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) From: Thiemo Seufer Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1808 Lines: 60 Maciej W. Rozycki wrote: > This a set of fixes mostly to make the driver actually work: > > 1. Actually select the line for setting parameters and receiver > disable/enable. > 2. Select the line for receive and transmit interrupt handling correctly. > 3. Report the transmitter empty state correctly. > 4. Set the I/O type of ports correctly. > 5. Perform polled transmission correctly. > 6. Don't fix the console line at ttyS3. > 7. Magic SysRq support. > 8. Various small bits here and there. > > Signed-off-by: Maciej W. Rozycki > --- > Tested with a DECstation 2100 (thanks Flo for making this possible). > > Please apply. > > Maciej > > patch-2.6.18-dz-13 > diff -up --recursive --new-file linux-2.6.18.macro/drivers/char/decserial.c linux-2.6.18/drivers/char/decserial.c > --- linux-2.6.18.macro/drivers/char/decserial.c 2006-09-20 03:42:06.000000000 +0000 > +++ linux-2.6.18/drivers/char/decserial.c 2006-11-23 18:29:38.000000000 +0000 > @@ -23,20 +23,12 @@ > extern int zs_init(void); > #endif > > -#ifdef CONFIG_DZ > -extern int dz_init(void); > -#endif > - > #ifdef CONFIG_SERIAL_CONSOLE > > #ifdef CONFIG_ZS > extern void zs_serial_console_init(void); > #endif > > -#ifdef CONFIG_DZ > -extern void dz_serial_console_init(void); > -#endif > - > #endif > > /* rs_init - starts up the serial interface - > @@ -46,23 +38,11 @@ extern void dz_serial_console_init(void) > > int __init rs_init(void) > { > - > -#if defined(CONFIG_ZS) && defined(CONFIG_DZ) > +#ifdef ONFIG_ZS ^ Minor typo. :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/