Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4987122pxv; Tue, 27 Jul 2021 23:44:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxq++xOgAeQfqcycja5G8UeNrp0dsdCWZIcS/cInxgiOWDjUkz0FHEKf7t/7WGt0yR/RXV X-Received: by 2002:a5e:dc0c:: with SMTP id b12mr21245816iok.141.1627454645867; Tue, 27 Jul 2021 23:44:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627454645; cv=none; d=google.com; s=arc-20160816; b=gY0qPEMRg6S+5JeKIk+JCh220MYZHbiyA3cxfrWltGi6vHazQVNDCHqy0Aebyi71gs ZXBCkJEm4rqWZf+7vLvtMkIbsb22F/sXbnDihxKuL3zl6n/1aH8RSMee7lxjgLFuuERo 0al0lxPoliBievhb4XvLt2VGoZMqXksvJoTFasyDzeG14a2sIQU/8dyi+/JKnBHj4PPe ZXTj55Cl7f70NY1xoBS055GpJB/z1hVxXPMvlo+iaLOroGq57jVGCdSRLrNyGyWr2cvH sqf5rTytV3olwESJy39iva/LwN/dbN8kg0akKabZ6Dykbfn5IivPpOeV1TFBsES3lI1V TlQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3no4rKjePVjW7IRv3Dz/h5LpWGdG2kl5xx+sJt/QKOU=; b=XDVY/PtFd19OoAmFlaenxiHfHcJdyxLy4IeI5EXQJ0PLtqiJmzIfUxuwQUiLOQdRh+ 8BWFB362c5v1IcZzk5GUdj54QNYrbfiWCDZCgOkSyTxnkrULmcl42aSDgMCBJwfxQVpt oYW17hxCpx+FxOZH0QrPClZwQVrxpA8+TYiy31qFKwKt4u2WydEYejt+IpAvnWel5DYy RVsUKYTTjqgvTBuK6poycSXbo+wPvbQ9uf7SBF5nCbUBaHciC1V6Z6KULQw0G9ngwdMm XaxLFc4P4E9MvFsJv5lVzsWBDf1Vp6GVLuBZG+MZXfgCrHwuSvcV4Md/ekbUlo0ZXKoI /HIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EdBFl8xE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si5685616ilf.150.2021.07.27.23.43.54; Tue, 27 Jul 2021 23:44:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EdBFl8xE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234844AbhG1Gl5 (ORCPT + 99 others); Wed, 28 Jul 2021 02:41:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:36988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232798AbhG1Gl4 (ORCPT ); Wed, 28 Jul 2021 02:41:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4CA4E60C41; Wed, 28 Jul 2021 06:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627454515; bh=qL5t703Mf1hPIHikLEKWuENxZ+pm60uKcC89JnlnnGg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EdBFl8xE5Jh+359Gi0XwIi4m2Vgkvmd5d/btAC48b9gG+YY4LRATfT87aLA+x5yMO GoJzseUiP7dolweKhN2pTNzyVSMNSWjWw85eYhy6FjHyzRMJPKijw1SvTdqRAikJfK /tUv2clQWaTXn8EWdPr8p+YufhLasp3W5Ji2bbCQ= Date: Wed, 28 Jul 2021 08:41:53 +0200 From: Greg KH To: Felipe Balbi Cc: Maxim Devaev , sandeen@redhat.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration Message-ID: References: <20210727185800.43796-1-mdevaev@gmail.com> <87mtq7t0ex.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mtq7t0ex.fsf@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2021 at 09:31:02AM +0300, Felipe Balbi wrote: > > Hi, > > Maxim Devaev writes: > > > SET_IDLE value must be shifted 8 bits to the right to get duration. > > This confirmed by USBCV test. > > > > Signed-off-by: Maxim Devaev > > with Greg's Fixes addition: > > Acked-by: Felipe Balbi Argh, just missed me committing this. Thanks for the review, sorry it missed getting added to the final commit :( greg k-h