Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20210727185800.43796-1-mdevaev@gmail.com>
 <87mtq7t0ex.fsf@kernel.org> <YQD8MfEZxPHYhnrz@kroah.com>
User-agent: mu4e 1.4.15; emacs 27.2
From:   Felipe Balbi <balbi@kernel.org>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Maxim Devaev <mdevaev@gmail.com>, sandeen@redhat.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_hid: idle uses the highest byte for
 duration
In-reply-to: <YQD8MfEZxPHYhnrz@kroah.com>
Date:   Wed, 28 Jul 2021 09:47:04 +0300
Message-ID: <87k0lbszo7.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Greg KH <gregkh@linuxfoundation.org> writes:
> On Wed, Jul 28, 2021 at 09:31:02AM +0300, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Maxim Devaev <mdevaev@gmail.com> writes:
>> 
>> > SET_IDLE value must be shifted 8 bits to the right to get duration.
>> > This confirmed by USBCV test.
>> >
>> > Signed-off-by: Maxim Devaev <mdevaev@gmail.com>
>> 
>> with Greg's Fixes addition:
>> 
>> Acked-by: Felipe Balbi <balbi@kernel.org>
>
> Argh, just missed me committing this.  Thanks for the review, sorry it
> missed getting added to the final commit :(

not a problem, thanks for taking care of all these patches ;-)

-- 
balbi