Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Jul 2021 12:22:13 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     wangzhou1@hisilicon.com, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: hisi_dma: Remove some useless code
Message-ID: <YQD+ncEBh4TiM406@matsya>
References: <4f8932e2d0d8d092bf60272511100030e013bc72.1623875508.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4f8932e2d0d8d092bf60272511100030e013bc72.1623875508.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk

On 16-06-21, 22:34, Christophe JAILLET wrote:
> When using 'pcim_enable_device()', 'pci_alloc_irq_vectors()' is
> auto-magically a managed function.
> 
> It is useless (but harmless) to record an action to explicitly call
> 'pci_free_irq_vectors()'.
> 
> So keep things simple, comment why and how these resources are freed, axe
> some useless code and save some memory.

Applied, thanks

-- 
~Vinod