Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Jul 2021 12:31:36 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Harini Katakam <harini.katakam@xilinx.com>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        harinikatakamlinux@gmail.com, michal.simek@xilinx.com,
        radhey.shyam.pandey@xilinx.com, shravya.kumbham@xilinx.com
Subject: Re: [PATCH] dmaengine: pl330: Typecast with enum to fix the coverity
 warning
Message-ID: <YQEA0DWG4X8U83/z@matsya>
References: <20210629103710.24828-1-harini.katakam@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210629103710.24828-1-harini.katakam@xilinx.com>
Precedence: bulk

On 29-06-21, 16:07, Harini Katakam wrote:
> From: Shravya Kumbham <shravya.kumbham@xilinx.com>
> 
> Typecast the flags and flg variables with (enum dma_ctrl_flags) in
> pl330_prep_dma_cyclic, pl330_prep_dma_memcpy and pl330_prep_slave_sg
> functions to fix the coverity warning.
> 
> Addresses-Coverity: Event mixed_enum_type.
> Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> ---
>  drivers/dma/pl330.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 110de8a60058..35afbad2e1a7 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2752,7 +2752,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
>  		return NULL;
>  
>  	pch->cyclic = true;
> -	desc->txd.flags = flags;
> +	desc->txd.flags = (enum dma_ctrl_flags)flags;

Does this driver use the txd.flags?

>  
>  	return &desc->txd;
>  }
> @@ -2804,7 +2804,7 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
>  
>  	desc->bytes_requested = len;
>  
> -	desc->txd.flags = flags;
> +	desc->txd.flags = (enum dma_ctrl_flags)flags;
>  
>  	return &desc->txd;
>  }
> @@ -2889,7 +2889,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
>  	}
>  
>  	/* Return the last desc in the chain */
> -	desc->txd.flags = flg;
> +	desc->txd.flags = (enum dma_ctrl_flags)flg;
>  	return &desc->txd;
>  }
>  
> -- 
> 2.17.1

-- 
~Vinod