Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965818AbWKXRdy (ORCPT ); Fri, 24 Nov 2006 12:33:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934999AbWKXRdy (ORCPT ); Fri, 24 Nov 2006 12:33:54 -0500 Received: from hp3.statik.TU-Cottbus.De ([141.43.120.68]:38880 "EHLO hp3.statik.tu-cottbus.de") by vger.kernel.org with ESMTP id S934996AbWKXRdx (ORCPT ); Fri, 24 Nov 2006 12:33:53 -0500 Message-ID: <45672D00.8060903@s5r6.in-berlin.de> Date: Fri, 24 Nov 2006 18:33:52 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.8) Gecko/20061030 SeaMonkey/1.0.6 MIME-Version: 1.0 To: Yan Burman CC: linux-kernel@vger.kernel.org, trivial@kernel.org, wli@holomorphy.com, sparclinux@vger.kernel.org Subject: Re: [PATCH 2.6.19-rc6] sparc: replace kmalloc+memset with kzalloc References: <4566DF0A.3050803@gmail.com> In-Reply-To: <4566DF0A.3050803@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1836 Lines: 42 Yan Burman wrote: ... > --- linux-2.6.19-rc5_orig/arch/sparc/kernel/sun4d_irq.c 2006-11-09 12:16:21.000000000 +0200 > +++ linux-2.6.19-rc5_kzalloc/arch/sparc/kernel/sun4d_irq.c 2006-11-11 22:44:04.000000000 +0200 > @@ -545,8 +545,7 @@ void __init sun4d_init_sbi_irq(void) > nsbi = 0; > for_each_sbus(sbus) > nsbi++; > - sbus_actions = (struct sbus_action *)kmalloc (nsbi * 8 * 4 * sizeof(struct sbus_action), GFP_ATOMIC); > - memset (sbus_actions, 0, (nsbi * 8 * 4 * sizeof(struct sbus_action))); > + sbus_actions = kzalloc (nsbi * 8 * 4 * sizeof(struct sbus_action), GFP_ATOMIC); > for_each_sbus(sbus) { > #ifdef CONFIG_SMP > extern unsigned char boot_cpu_id; I'm not sure about this ^ hunk, but... > diff -rubp linux-2.6.19-rc5_orig/arch/sparc/mm/io-unit.c linux-2.6.19-rc5_kzalloc/arch/sparc/mm/io-unit.c > --- linux-2.6.19-rc5_orig/arch/sparc/mm/io-unit.c 2006-11-09 12:16:21.000000000 +0200 > +++ linux-2.6.19-rc5_kzalloc/arch/sparc/mm/io-unit.c 2006-11-11 22:44:04.000000000 +0200 > @@ -41,9 +41,8 @@ iounit_init(int sbi_node, int io_node, s > struct linux_prom_registers iommu_promregs[PROMREG_MAX]; > struct resource r; > > - iounit = kmalloc(sizeof(struct iounit_struct), GFP_ATOMIC); > + iounit = kzalloc(sizeof(struct iounit_struct), GFP_ATOMIC); > > - memset(iounit, 0, sizeof(*iounit)); > iounit->limit[0] = IOUNIT_BMAP1_START; > iounit->limit[1] = IOUNIT_BMAP2_START; > iounit->limit[2] = IOUNIT_BMAPM_START; ...in this ^, the old code and your update don't check for NULL return. -- Stefan Richter -=====-=-==- =-== ==--- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/