Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5069658pxv; Wed, 28 Jul 2021 02:17:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTmU3Fsj8O+tgtUHeFRijkgH8JU1xdVgQ2Qk8uz1ZPG1VHl/J8kENLPL0N0too+XNAp0sE X-Received: by 2002:aa7:c412:: with SMTP id j18mr32020371edq.119.1627463826191; Wed, 28 Jul 2021 02:17:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627463826; cv=none; d=google.com; s=arc-20160816; b=mwYR8ZcHYshrHHBcorMLHcDzNi1TOT6VL7lhPac5nVpRTESM20VB9Bozshzr0eVh96 r0eEP8elCo/UEyz/IGCepvgh/GtZmoMpH7yA3zAue3MLTe5BzkvmCK8E5T4eTs7wmUQs SVP3HIkrPkYVAUfZaKtDB9v9FIAAm+PQIi6135K/oMvekaWkL6941WOSmJ0z1wwXkjHf Ug0FV8xEclpf58eprGduGRLckkh3J4JxvNZY4I0Ga8AqCoo6tNFPEouz7xStPzlK7jfD nPtrOIeElmOq2MkPqMmMW3h9XVJ0qHS2MhFDFCwkzUaImCCmDDbZUdRqYamy/ezpxl6U SgoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:date :subject:cc:to:from; bh=JJOcvU5KTQ1kdL70pZxDpudhDR+mfjEKMXWDeeGeES0=; b=d8JjhT61I3jqmj4SloSS0DIMDhMiPn0mEV+jZEfOxeImbcz1VD9kEVRmbC7F0L6hoK MnXm8ta0x9B3CrpH9aySg99zWToX6YjWG2vHlJQBcx1wtGzqIM4RoIC7cUUJrtpMIKEG 4Jf7A5e61otvtymdENxQILHtkGnqqa2y2om5Sdw1yZWwx9MmJbgv1jkYrGWX4tjzEvWM 1tCTJe7YHgmO7mBUdhEgmbQiKCCG2CmTzpL0x+AjSljVug+owaOHip6mO2vuHH7hB8VD xEV/rzxx6XncDuINsATGTqjOyNAebh7gIlrXcXoEGWHXa32ds73RvLDIdcjaTWjJ2Ey+ E+mA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=puri.sm Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qk43si4640738ejc.325.2021.07.28.02.16.43; Wed, 28 Jul 2021 02:17:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=puri.sm Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235504AbhG1JNl (ORCPT + 99 others); Wed, 28 Jul 2021 05:13:41 -0400 Received: from comms.puri.sm ([159.203.221.185]:37418 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235471AbhG1JNc (ORCPT ); Wed, 28 Jul 2021 05:13:32 -0400 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 41581E0E7D; Wed, 28 Jul 2021 02:13:01 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zuZBgGbAAueh; Wed, 28 Jul 2021 02:12:56 -0700 (PDT) From: Martin Kepplinger To: laurent.pinchart@ideasonboard.com, dafna.hirschfeld@collabora.com, shawnguo@kernel.org Cc: devicetree@vger.kernel.org, festevam@gmail.com, kernel@pengutronix.de, kernel@puri.sm, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, m.felsch@pengutronix.de, mchehab@kernel.org, phone-devel@vger.kernel.org, robh@kernel.org, slongerbeam@gmail.com, Martin Kepplinger Subject: [PATCH v10 0/3] media: imx: add support for imx8mq MIPI RX Date: Wed, 28 Jul 2021 11:12:42 +0200 Message-Id: <20210728091245.231043-1-martin.kepplinger@puri.sm> Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, This patch series adds a driver for the i.MX8MQ CSI MIPI receiver / controller. It includes the driver, the dt-bindings and the DT addition to the SoC dtsi. I test it using libcamera. Thanks to Laurent who helped a lot. I'm happy for any feedback, martin revision history ---------------- v10: (thank you Dafna) * improve send_level documentation. * add some comments to 0x180 and 0x184 * after re-reading I could eliminate the unneeded setting of 0x184 (ignored by setting 0x180 to 1). v9: (thank you Laurent) * improve getting the esc clock rate for hs_settle https://lore.kernel.org/linux-media/20210726082117.2423597-1-martin.kepplinger@puri.sm/ v8: (thank you Laurent) * calculate hs_settle for any clk rate and mode * add reviewed-by tag https://lore.kernel.org/linux-media/20210723101217.1954805-1-martin.kepplinger@puri.sm/T/ v7: (thank you Laurent and Rob) * fix the binding example (include the reset driver) * use pm_runtime_resume_and_get() * fix some logic in init_cfg() * add some useful code comments and fix minor bits found by Laurent in v6 https://lore.kernel.org/linux-media/20210716102244.581182-1-martin.kepplinger@puri.sm/T/#t v6: (thank you Laurent and Rob) * add reviewed-by tag to binding * statically allocate clk_bulk_data * fix how the hs_settle value is applied * remove s_power calls * remove the link_setup() callback implementation and make the link immutable * more cleanups according to Laurents' review from v5 https://lore.kernel.org/linux-media/20210714111931.324485-1-martin.kepplinger@puri.sm/ v5: (thank you Laurent) * fix reset usage by using the already supported reset controller driver * remove clko2 (totally unrelated clock / had been included by accident) * rename pxl clock to ui https://lore.kernel.org/linux-media/20210618095753.114557-1-martin.kepplinger@puri.sm/ v4: (thank you Rob and Marco) * create fsl,mipi-phy-gpr custom dt property instead of confusing "phy" * add imx8mq-specific compatibile to imx8mq.dtsi for future use https://lore.kernel.org/linux-media/20210614121522.2944593-1-martin.kepplinger@puri.sm/ v3: (thank you, Rob and Laurent) among minor other things according to v2 review, changes include: * better describe the clocks * rename DT property "phy-reset" to "reset" and "phy-gpr" to "phy" https://lore.kernel.org/linux-media/20210608104128.1616028-1-martin.kepplinger@puri.sm/T/#t v2: (thank you, Dan and Guido) among fixes according to v1 reviews, changes include: * remove status property from dt-bindings example * define a few bits in order to have less magic values * use "imx8mq_mipi_csi_" as local function prefix * read DT properties only during probe() * remove dead code (log_status) * add imx8mq_mipi_csi_release_icc() * fix imx8mq_mipi_csi_init_icc() https://lore.kernel.org/linux-media/20210531112326.90094-1-martin.kepplinger@puri.sm/ v1: https://lore.kernel.org/linux-media/20210527075407.3180744-1-martin.kepplinger@puri.sm/T/#t Martin Kepplinger (3): dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and controller media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 174 +++ arch/arm64/boot/dts/freescale/imx8mq.dtsi | 104 ++ drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx8mq-mipi-csi2.c | 991 ++++++++++++++++++ 4 files changed, 1270 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml create mode 100644 drivers/staging/media/imx/imx8mq-mipi-csi2.c -- 2.30.2