Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Jul 2021 11:35:20 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     =?ISO-8859-15?Q?Jos=E9_Exp=F3sito?= <jose.exposito89@gmail.com>
cc:     benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] HID: magicmouse: register power supply
In-Reply-To: <20210625170834.GA9573@elementary-os.localdomain>
Message-ID: <nycvar.YFH.7.76.2107281134430.8253@cbobk.fhfr.pm>
References: <20210522180611.314300-1-jose.exposito89@gmail.com> <nycvar.YFH.7.76.2106241532511.18969@cbobk.fhfr.pm> <20210625170834.GA9573@elementary-os.localdomain>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, 25 Jun 2021, Jos? Exp?sito wrote:

> > > [...]
> > > v2: Add depends on USB_HID to Kconfig
> > 
> > Hmm, why is this dependency needed in the first place, please? I think 
> > trying to keep the drivers independent on transport drivers (especially in 
> > cases like this, where more variants of physical transports actually 
> > really do exist) is worth trying.
> 
> Sorry, that's something I should have explained in the changelog.
> 
> Intel's test bot reported compilation errors on the first version of the patch
> when USB support wasn't configured:
> https://lore.kernel.org/patchwork/patch/1425313/
> 
> I was kindly pointed to a similar error and its fix, but, maybe in this case this
> is not the right fix?
> Maybe there is a macro that I can use to wrap the USB related code in an #ifdef?

It can certainly be wrapped, but looking into the code now, it probably 
wouldn't really bring more clarity. I will apply the series with adding 
the USB_HID dependency for now.

Thanks,

-- 
Jiri Kosina
SUSE Labs