Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5088254pxv; Wed, 28 Jul 2021 02:48:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztlbHXBdyW4Qaw+boIF+ESgUfV+Jsk4SuPoRYLmG+jtOBANMGGkWcuJC9/3mfH8qwDWdC4 X-Received: by 2002:a92:8e41:: with SMTP id k1mr20763120ilh.276.1627465726142; Wed, 28 Jul 2021 02:48:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627465726; cv=none; d=google.com; s=arc-20160816; b=ZW0mYKvQFyJwzacgGGU/gfyhefjuGDvrXJyD/t25qY83KwJ5kgmHP4iD/eJ3RSJQx7 jF1XpqCV6gXJNgebmUnz8zgiPVs5kIc+9h5F9wAAtrlI9AsBspV63lzZ0PtAWhJoGLVs +K+fgmF5s7n3B0oQqeIWjGs92reO/Bf1JPWMZ59wBSx9J7uXvw51B8Cizbn7tHqHLxXi 8HgqHhjTBSX4LKSoyxSFE0+TQUa5K9GgRkxEG6qTIVsetr6vMFZPDOXdCeR3vnpbRTIV DlS0fXVFWgMiiaaDkfdw3zWirvXNDxR8MC57MqzwBWVbjcaravTocqMx0gvJKCXLHl+8 I0zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=4+2UUka0Z/Vok0/sipzhgCZNojJxdXMHK2mFcpVMs+I=; b=GMPWfoyFxQXJ82zlQlzhQ0iS+g5JSPNGLgUO8s83WrlKySaTI1L3/ItYbb8PX+r8dd ZQcuT3I/yZFt3eFwuChjH3hs0sUIe+QWlZCsbLmBJHTY8crQKeXa7Uae6Zvg4bbM2qcU O71DZFMsPVeouis81vxXypONUDJsQ1ltlqwgT/1O7skZ0ElTppYKsP8rClBrtOjHVtgz IfC3a/l0N8yC80dsdkLUVOoTCVnx0sx1ZNh9zF9HAGJtY8sCRhRlLIEYRk8/bMSzgOB9 VNGJ1ZH2YdJ6uTpsA3Jsaa3ACfMNSMYCjlJBC+VEe/0krrhZOHqg9RlXdOhORpfMSImf 5eyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JgaXlVJV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t26si6253389ioj.103.2021.07.28.02.48.35; Wed, 28 Jul 2021 02:48:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JgaXlVJV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231733AbhG1Jrx (ORCPT + 99 others); Wed, 28 Jul 2021 05:47:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:54178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231443AbhG1Jrw (ORCPT ); Wed, 28 Jul 2021 05:47:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 426CE60F9C; Wed, 28 Jul 2021 09:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627465671; bh=6hpI4gRiWIN0fd0eWFY8c/aNxVDe6Fb04bV/5DieHMs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JgaXlVJV2SOl/SVyqvfOTu0cWCNbQrfGWwba3ODmZcza6w2FBsYKR8xlCwRWSymFj GJgz7B2Lcp5HGYOiWPmNc77VyyjkaeOXKKrw86tjUt9PbptZJKDqRnqtaBy0bhqmmB HwsHRYxJL0icYO1q5yXxVxWQrZUPsfLFrLTFH50hhTrx1pe5oGtcZL96IKS2QD8FeM WMON57/gMMQhxFRXYxCaxTM4cyMhACw2MgyOIbIn0QiYkXuAtaBY/YdqX0irVnxKYy 9STYGblZeWjZVL4/w86X0VUEOMjuTwnAUlwaDTOY3qs0HOvq12urkRr1IvDz0uTXWI m5DjaPuorxsQA== Date: Wed, 28 Jul 2021 11:47:48 +0200 (CEST) From: Jiri Kosina To: Michael Zaidman cc: benjamin.tissoires@redhat.com, aaron.jones@ftdichip.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v1] HID: ft260: fix device removal due to USB disconnect In-Reply-To: <20210720144954.5392-1-michael.zaidman@gmail.com> Message-ID: References: <20210720144954.5392-1-michael.zaidman@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jul 2021, Michael Zaidman wrote: > This commit fixes a regression introduced by the commit 82f09a637dd3 > ("HID: ft260: improve error handling of ft260_hid_feature_report_get()") > when upon USB disconnect, the ft260 i2c device is still available within > the /dev folder. Thanks for the fix. Could you please make the changelog a little bit more verbose though? Namely describe the issue in the code the patch is fixing (and how). Thanks, -- Jiri Kosina SUSE Labs