Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210707093632.1468127-1-maxime@cerno.tech> <20210707093632.1468127-2-maxime@cerno.tech>
In-Reply-To: <20210707093632.1468127-2-maxime@cerno.tech>
From:   Dave Stevenson <dave.stevenson@raspberrypi.com>
Date:   Wed, 28 Jul 2021 12:01:34 +0100
Message-ID: <CAPY8ntAAE+N79T7Q15URHRkGf+N6f2DKNjtyp+74AFjNdb3Prg@mail.gmail.com>
Subject: Re: [PATCH 2/2] drm/vc4: hdmi: Remove unused struct
To:     Maxime Ripard <maxime@cerno.tech>
Cc:     DRI Development <dri-devel@lists.freedesktop.org>,
        Daniel Vetter <daniel.vetter@intel.com>,
        David Airlie <airlied@linux.ie>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        bcm-kernel-feedback-list@broadcom.com,
        Daniel Vetter <daniel@ffwll.ch>,
        Phil Elwell <phil@raspberrypi.com>,
        Tim Gover <tim.gover@raspberrypi.com>,
        Dom Cobley <dom@raspberrypi.com>,
        Emma Anholt <emma@anholt.net>,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-rpi-kernel@lists.infradead.org,
        Maxime Ripard <mripard@kernel.org>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 7 Jul 2021 at 10:36, Maxime Ripard <maxime@cerno.tech> wrote:
>
> Commit 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec") removed the
> references to the vc4_hdmi_audio_component_drv structure, but not the
> structure itself resulting in a warning. Remove it.
>
> Fixes: 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 3165f39a4557..1bb06c872175 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -1403,18 +1403,6 @@ static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = {
>         { "TX", NULL, "Playback" },
>  };
>
> -static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = {
> -       .name                   = "vc4-hdmi-codec-dai-component",
> -       .dapm_widgets           = vc4_hdmi_audio_widgets,
> -       .num_dapm_widgets       = ARRAY_SIZE(vc4_hdmi_audio_widgets),
> -       .dapm_routes            = vc4_hdmi_audio_routes,
> -       .num_dapm_routes        = ARRAY_SIZE(vc4_hdmi_audio_routes),
> -       .idle_bias_on           = 1,
> -       .use_pmdown_time        = 1,
> -       .endianness             = 1,
> -       .non_legacy_dai_naming  = 1,
> -};
> -
>  static const struct snd_soc_component_driver vc4_hdmi_audio_cpu_dai_comp = {
>         .name = "vc4-hdmi-cpu-dai-component",
>  };
> --
> 2.31.1
>