Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Jul 2021 20:52:48 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Yajun Deng <yajun.deng@linux.dev>
Cc:     davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "net: Get rid of consume_skb when tracing is off"
Message-ID: <20210728125248.GC2598@gondor.apana.org.au>
References: <20210728035605.24510-1-yajun.deng@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210728035605.24510-1-yajun.deng@linux.dev>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Jul 28, 2021 at 11:56:05AM +0800, Yajun Deng wrote:
> This reverts commit be769db2f95861cc8c7c8fedcc71a8c39b803b10.
> There is trace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is
> also a trace function.
> 
> Fixes: be769db2f958 (net: Get rid of consume_skb when tracing is off)
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>

Please explain in more detail why your patch is needed.  As it
stands I do not understand the reasoning.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt