Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Jul 2021 15:27:41 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Robert Foss <robert.foss@linaro.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        David Airlie <airlied@linux.ie>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI
 bridges
Message-ID: <20210728132741.dzqqohi34cm56q6j@gilmour>
References: <20210720134525.563936-1-maxime@cerno.tech>
 <20210720134525.563936-5-maxime@cerno.tech>
 <YPgNbVoNnq3fTMN2@phenom.ffwll.local>
 <20210726151657.c46qmkdvqfhlg6ox@gilmour>
 <YP/P9rJrZyk6zjsT@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xeh2a4js4i5wzele"
Content-Disposition: inline
In-Reply-To: <YP/P9rJrZyk6zjsT@phenom.ffwll.local>
Precedence: bulk


--xeh2a4js4i5wzele
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jul 27, 2021 at 11:20:54AM +0200, Daniel Vetter wrote:
> On Mon, Jul 26, 2021 at 05:16:57PM +0200, Maxime Ripard wrote:
> > Hi Daniel,
> >=20
> > On Wed, Jul 21, 2021 at 02:05:01PM +0200, Daniel Vetter wrote:
> > > On Tue, Jul 20, 2021 at 03:45:19PM +0200, Maxime Ripard wrote:
> > > > Interactions between bridges, panels, MIPI-DSI host and the compone=
nt
> > > > framework are not trivial and can lead to probing issues when
> > > > implementing a display driver. Let's document the various cases we =
need
> > > > too consider, and the solution to support all the cases.
> > > >=20
> > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > >=20
> > > I still have this dream that eventually we resurrect a patch to add
> > > device_link to bridges/panels (ideally automatically), to help with s=
ome
> > > of the suspend/resume issues around here.
> > >=20
> > > Will this make things worse?
> > >=20
> > > I think it'd be really good to figure that out with some coding, sinc=
e if
> > > we have incompatible solution to handle probe issues vs suspend/resume
> > > issues, we're screwed.
> > >=20
> > > Atm the duct-tape is to carefully move things around between suspend =
and
> > > suspend_early hooks (and resume and resume_late) and hope it all work=
s ...
> >=20
> > My initial idea to fix this was indeed to use device links. I gave up
> > after a while since it doesn't look like there's a way to add a device
> > link before either the bridge or encoder probes.
> >=20
> > Indeed the OF-Graph representation is device-specific, so it can't be
> > generic, and if you need to probe to add that link, well, it's already
> > too late for the probe ordering :)
>=20
> But don't we still need the device_link for suspend/resume and module
> reload? All very annoying indeed anyway.

I guess we would still need it for proper suspend and resume ordering
(but I never really worked on that part, so I'm not sure), but it's a
bit orthogonal to the issue here since those can be added after probe

Maxime

--xeh2a4js4i5wzele
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYQFbTQAKCRDj7w1vZxhR
xSEmAPwOxQqXDdghNM0po6K1BOfqhKogINFRlAFlP5KeBW1/NAEA2aO57tmIfUAX
GMjL4BMs5AuKDiq2tZVSX3PJcror+wg=
=fRPC
-----END PGP SIGNATURE-----

--xeh2a4js4i5wzele--