Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5272901pxv; Wed, 28 Jul 2021 07:10:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxK1XApwzHkhHeMTzwA1vMl+mP7Qhp0WUZVHL86QFtzDwzUn8CgUgHOEta/GytGkEwPhzdH X-Received: by 2002:a92:c150:: with SMTP id b16mr68615ilh.54.1627481415552; Wed, 28 Jul 2021 07:10:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627481415; cv=none; d=google.com; s=arc-20160816; b=T5ZIcAzuJTAed/FuWVgl1T2oUurB5gbOUj4rJZXY/7dU/3CkcMHColZn4j9wv2pNKw UNzU5FGNDcMY34i/zti3d+h1uzvqZUhdxP3MKAMv+KCA+h44k1ZoT8fA+BjSw3ozjOwM yqWAxqDkGBm1cA7YHsFTmJ4VJhzuwQ7/gCE4SwOzQ2IQrSgHFvNZTfStqQ7SJXjaJwCI 8xbVGS5TU3IAgzHu6tYxyaKRNswgAiDRMSDoDv6/5xahVMZMFvAzSJrlMHzsY+PZ41OL NrYafYQMRfZoVxPmNQI140TXoXL8Jn6Dfv+lZuCkRuAYfv8WHN0yuZkJHpI/HRl3w4w7 cHFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=p1ZPqb4JnoiqJdUy3vnukyeR01HwkRN6PlUru+n8cQk=; b=V76Yx60WbNAVB2prdtyt7hKY3WsG/okV9ZxS8/PMsPWTOYzAYXnTUXydFew28fBEyz JcDLHVnVP7VGm9XexJvyWQaR6sSYKK3GFyLujnUjKXPFpO5xOXRC5JNmSaYkvI9b8sWo 5qqDfJVBzryWIZI6iQFkOwG5kTANvtBilg2j6a7tjprOzz7XzRE1qn3S07G22HxHUFLn 9SC73wc+5ONeMDykOm3QCfcxt8+RQzeMRXzgf+abIod2wubziGQbVIXZ3XeYoMvUme0a ZRGvgGnlA0NEj9JvoT9H0CLN+NwjJHwJXTcSOmSmx+jBA0x5snxMsybwqqnNBRayH4q3 ZREQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3H8BpUcZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b9si33194jal.24.2021.07.28.07.10.04; Wed, 28 Jul 2021 07:10:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3H8BpUcZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236604AbhG1OIU (ORCPT + 99 others); Wed, 28 Jul 2021 10:08:20 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49904 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233439AbhG1OIT (ORCPT ); Wed, 28 Jul 2021 10:08:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=p1ZPqb4JnoiqJdUy3vnukyeR01HwkRN6PlUru+n8cQk=; b=3H8BpUcZNCR7qZ5elLTY+OrAXg lW2dhXJwczo0A9Xdg+esFXvfYBmqWRwlM5parI7UKDosoXS09/yQHSyFDDf1U96dVK01wie9SxHjQ 9Wmm0BxPjA7ovj/f4eJJcUooQQLz6Rzy0BXOQyxZtp4C/Yx35EyWVPxYAt9uaU2ya0Hc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m8kEE-00FB6E-5W; Wed, 28 Jul 2021 16:08:10 +0200 Date: Wed, 28 Jul 2021 16:08:10 +0200 From: Andrew Lunn To: Joakim Zhang Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 net-next 2/7] dt-bindings: net: fsl,fec: add RGMII internal clock delay Message-ID: References: <20210728115203.16263-1-qiangqing.zhang@nxp.com> <20210728115203.16263-3-qiangqing.zhang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728115203.16263-3-qiangqing.zhang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2021 at 07:51:58PM +0800, Joakim Zhang wrote: > + The "enet_2x_txclk"(option), for RGMII sampling clock which fixed at 250Mhz. > + The clock is required if SoC RGMII enable clock delay. Hi Joakim So you only need the clock if you are using RGMII delays? For RGMII without delays, the clock is not needed? You might want to add a check in the C code that the clock is provided when needed. Andrew