Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934214AbWKXXCW (ORCPT ); Fri, 24 Nov 2006 18:02:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757552AbWKXXCV (ORCPT ); Fri, 24 Nov 2006 18:02:21 -0500 Received: from hancock.steeleye.com ([71.30.118.248]:55707 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S1757508AbWKXXCV (ORCPT ); Fri, 24 Nov 2006 18:02:21 -0500 Subject: Re: [PATCH]: scsi: in2000 scsi_cmnd convertion From: James Bottomley To: Henne Cc: Andrew Morton , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <45659882.1060201@nachtwindheim.de> References: <45659882.1060201@nachtwindheim.de> Content-Type: text/plain Date: Fri, 24 Nov 2006 17:01:43 -0600 Message-Id: <1164409303.2813.21.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 (2.6.3-1.fc5.5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1362 Lines: 31 On Thu, 2006-11-23 at 13:48 +0100, Henne wrote: > - volatile Scsi_Cmnd *input_Q; /* commands waiting to be started */ > - volatile Scsi_Cmnd *selecting; /* trying to select this command */ > - volatile Scsi_Cmnd *connected; /* currently connected command */ > - volatile Scsi_Cmnd *disconnected_Q;/* commands waiting for reconnect */ > + volatile struct scsi_cmnd *input_Q; > + /* commands waiting to be started */ > + volatile struct scsi_cmnd *selecting; > + /* trying to select this command */ > + volatile struct scsi_cmnd *connected; > + /* currently connected command */ > + volatile struct scsi_cmnd *disconnected_Q; This doesn't preserve the indentation of the original. Plus, I think if you lose the volatile then a lot of pointless casts like this one: > - tmp = (Scsi_Cmnd *) hostdata->input_Q; > + tmp = (struct scsi_cmnd *) hostdata->input_Q; Can be eliminated entirely (its sole job is to drop the volatile again). James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/