Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Jul 2021 19:45:27 +0200
From:   Len Baker <len.baker@gmx.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Len Baker <len.baker@gmx.com>,
        David Laight <David.Laight@ACULAB.COM>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Pavel Skripkin <paskripkin@gmail.com>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/rtl8712: Remove all strcpy() uses in favor of
 strscpy()
Message-ID: <20210728174527.GA4275@titan>
References: <20210717155145.15041-1-len.baker@gmx.com>
 <20210719053747.GN1931@kadam>
 <de94438319a84e0985b3ba0f5c00807b@AcuMS.aculab.com>
 <20210721080624.GV1931@kadam>
 <20210723151510.GB2612@titan>
 <20210726081148.GF1931@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210726081148.GF1931@kadam>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 26, 2021 at 11:11:48AM +0300, Dan Carpenter wrote:
> On Fri, Jul 23, 2021 at 05:15:10PM +0200, Len Baker wrote:
> > Hi,
> >
> > On Wed, Jul 21, 2021 at 11:06:24AM +0300, Dan Carpenter wrote:
> > > On Mon, Jul 19, 2021 at 03:24:38PM +0000, David Laight wrote:
> > > >
> > > > I know only root can set module parameters, but having one
> > > > that contains a string used as a printf format seems
> > > > dangerous at best.
> > > >
> > > > Isn't it best to let userspace rename the interfaces later on?
> > >
> > > Yeah.  I think you're right.
> >
> > Sorry, but I don't understand if the code needs to be improved or not.
> > Is the code shown by Dan not correct?
>
> We should remove the ifname[] array and the module option completely.

Thanks for the clarification.

Regards,
Len