Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/4] configfs: Fix writing at a non-zero offset
To:     Bodo Stroesser <bostroesser@gmail.com>,
        Christoph Hellwig <hch@lst.de>
Cc:     Joel Becker <jlbec@evilplan.org>, linux-kernel@vger.kernel.org,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Yanko Kaneti <yaneti@declera.com>,
        Brendan Higgins <brendanhiggins@google.com>
References: <20210723212353.896343-1-bvanassche@acm.org>
 <20210723212353.896343-3-bvanassche@acm.org>
 <7bee65ce-f5f1-a525-c72d-221b5d23cf3e@gmail.com>
 <d12f24b6-7066-f9bb-1b88-6cc23c9c45c1@acm.org>
 <4055ca70-7669-d00d-7c08-86fe75a3d377@gmail.com>
 <618b2bdc-282b-0a1d-1fc5-020cf80d7a7e@acm.org>
 <c9cb1f3b-0b3b-c571-4a51-e647f3c1e90a@gmail.com>
 <ab190c50-8c87-b215-1432-056c81bcd656@acm.org>
 <fec30933-46b1-1085-1af1-1fd0d2265981@gmail.com>
 <a3ba73e5-ffd1-887e-acd9-11f537db27e0@acm.org>
 <b33a5330-472b-9961-c590-5c07420cf9de@gmail.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <70ed90fc-9de0-efcf-b591-8f1accc7dda6@acm.org>
Date:   Wed, 28 Jul 2021 10:55:17 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <b33a5330-472b-9961-c590-5c07420cf9de@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/28/21 10:14 AM, Bodo Stroesser wrote:
> I reviewed and tested the new patch. For me it works fine.
> 
> Just one warning to fix:
> 
> fs/configfs/file.c: In function ‘fill_write_buffer’:
> fs/configfs/file.c:184:6: warning: unused variable ‘to_copy’ [-Wunused-variable]
>    int to_copy, copied;
>        ^~~~~~~
> 
> Apart from that you can add my tested-by or reviewed-by if you want.

I will remove the 'to_copy' variable and also add your Tested-by. Thanks for
having tested this patch!

Bart.