Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Wed, 28 Jul 2021 11:04:34 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] watchdog: mpc8xxx_wdt: Constify static struct
 watchdog_ops
Message-ID: <20210728180434.GC1663715@roeck-us.net>
References: <20210727223042.48150-1-rikard.falkeborn@gmail.com>
 <20210727223042.48150-4-rikard.falkeborn@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210727223042.48150-4-rikard.falkeborn@gmail.com>
Precedence: bulk

On Wed, Jul 28, 2021 at 12:30:42AM +0200, Rikard Falkeborn wrote:
> The struct mpc8xxx_wdt_ops is only assigned to the ops pointer in the
> watchdog_device struct, which is a pointer to const struct watchdog_ops.
> Make it const to allow the compiler to put it in read-only memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/mpc8xxx_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/mpc8xxx_wdt.c b/drivers/watchdog/mpc8xxx_wdt.c
> index 2f7ded32e878..1c569be72ea2 100644
> --- a/drivers/watchdog/mpc8xxx_wdt.c
> +++ b/drivers/watchdog/mpc8xxx_wdt.c
> @@ -118,7 +118,7 @@ static struct watchdog_info mpc8xxx_wdt_info = {
>  	.identity = "MPC8xxx",
>  };
>  
> -static struct watchdog_ops mpc8xxx_wdt_ops = {
> +static const struct watchdog_ops mpc8xxx_wdt_ops = {
>  	.owner = THIS_MODULE,
>  	.start = mpc8xxx_wdt_start,
>  	.ping = mpc8xxx_wdt_ping,
> -- 
> 2.32.0
>