Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH v10 2/8] PCI: Add new array for keeping track of ordering
 of reset methods
To:     Amey Narkhede <ameynarkhede03@gmail.com>,
        Bjorn Helgaas <helgaas@kernel.org>
CC:     <alex.williamson@redhat.com>,
        Raphael Norwitz <raphael.norwitz@nutanix.com>,
        <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kw@linux.com>, Sinan Kaya <okaya@kernel.org>,
        Len Brown <lenb@kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>
References: <20210709123813.8700-3-ameynarkhede03@gmail.com>
 <20210727225951.GA752728@bjorn-Precision-5520>
 <20210728174519.has5xvy6rksbukup@archlinux>
From:   Shanker R Donthineni <sdonthineni@nvidia.com>
Message-ID: <e8ad2686-22e8-7d75-f0f4-82c0c57fc65e@nvidia.com>
Date:   Wed, 28 Jul 2021 13:08:36 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210728174519.has5xvy6rksbukup@archlinux>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2021 18:08:40.8901
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 320faaf6-f7aa-4906-0780-08d951f2baf3
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT020.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2473
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Amey,

On 7/28/21 12:45 PM, Amey Narkhede wrote:
>>> +   BUILD_BUG_ON(ARRAY_SIZE(pci_reset_fn_methods) != PCI_NUM_RESET_METHODS);
>>>
>>>     might_sleep();
>>>
>>> -   rc = pci_dev_specific_reset(dev, 1);
>>> -   if (rc != -ENOTTY)
>>> -           return rc;
>>> -   rc = pcie_reset_flr(dev, 1);
>>> -   if (rc != -ENOTTY)
>>> -           return rc;
>>> -   rc = pci_af_flr(dev, 1);
>>> -   if (rc != -ENOTTY)
>>> -           return rc;
>>> -   rc = pci_pm_reset(dev, 1);
>>> -   if (rc != -ENOTTY)
>>> -           return rc;
>>> +   for (i = 1; i < PCI_NUM_RESET_METHODS; i++) {
>>> +           rc = pci_reset_fn_methods[i].reset_fn(dev, 1);
>>> +           if (!rc)
>>> +                   reset_methods[n++] = i;
>> Why do we need this local reset_methods[] array?  Can we just fill
>> in dev->reset_methods[] directly and skip the memcpy() below?
>>
> This is for avoiding caching of previously supported reset methods.
> Is it okay if I use memset(dev->reset_methods, 0,
> sizeof(dev->reset_methods)) instead to clear the values in
> dev->reset_methods?

Clearing the array before the loop might a better option, we can get rid of a local variable.

void pci_init_reset_methods(struct pci_dev *dev)
{
        int i, n, rc;

        BUILD_BUG_ON(ARRAY_SIZE(pci_reset_fn_methods) != PCI_NUM_RESET_METHODS);

        might_sleep();

        memset(dev->reset_methods, 0x0, sizeof(reset_methods));

        n = 0;
        for (i = 1; i < PCI_NUM_RESET_METHODS; i++) {
                rc = pci_reset_fn_methods[i].reset_fn(dev, 1);
                if (!rc)
                        dev->reset_methods[n++] = i;
                else if (rc != -ENOTTY)
                        break;
        }
}