Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Larry Finger <larry.finger@gmail.com>
Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu
 driver
To:     Greg KH <gregkh@linuxfoundation.org>,
        Phillip Potter <phil@philpotter.co.uk>
Cc:     dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, fabioaiuto83@gmail.com,
        martin@kaiser.cx
References: <20210727232219.2948-1-phil@philpotter.co.uk>
 <YQGenmf2m3Tu7FFg@kroah.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <9902deed-021c-ad37-7fc7-f4279886c683@lwfinger.net>
Date:   Wed, 28 Jul 2021 13:41:15 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YQGenmf2m3Tu7FFg@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/28/21 1:14 PM, Greg KH wrote:
> Hm, I thought this would be in better shape than it is.
> 
> Right now we have 107 .c and .h files in drivers/staging/rtl8188eu/ that
> come to a total of 44597 lines.
> 
> So we are taking double the size here?
> 
> I'm all for putting a "better" driver in here, but this feels odd to
> me...  Is there major new functionality here that is not in the existing
> driver to justify this?
> 
> Ok, let's see how this goes, I'll give it a few weeks to see how much
> can easily be fixed up to hopefully get back to at least close the
> existing driver size...

The major new functionality is that the new one uses cfg80211, whereas the old 
one uses the WEXT calls.

It really is an improvement. It just needs a severe cleanup.

I warned you that this code was rough. It took me several weeks to get the old 
one "ready" for staging. I never devoted that effort to the new one, and you 
wanted it in a place where multiple authors could improve it.

Larry