Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210727103251.16561-1-pbonzini@redhat.com>
In-Reply-To: <20210727103251.16561-1-pbonzini@redhat.com>
From:   Oliver Upton <oupton@google.com>
Date:   Wed, 28 Jul 2021 12:02:33 -0700
Message-ID: <CAOQ_Qsg+mwmcuht=rQrqNdzaTGKgak0BQwFHzSj=9RZdK9tB5w@mail.gmail.com>
Subject: Re: [PATCH] KVM: ARM: count remote TLB flushes
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org, maz@kernel.org,
        kvmarm@lists.cs.columbia.edu, Jing Zhang <jingzhangos@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 27, 2021 at 3:33 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> KVM/ARM has an architecture-specific implementation of
> kvm_flush_remote_tlbs; however, unlike the generic one,
> it does not count the flushes in kvm->stat.remote_tlb_flush,
> so that it inexorably remained stuck to zero.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Oliver Upton <oupton@google.com>

> ---
>  arch/arm64/kvm/mmu.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index c10207fed2f3..6cf16b43bfcc 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
> @@ -81,6 +81,7 @@ static bool memslot_is_logging(struct kvm_memory_slot *memslot)
>  void kvm_flush_remote_tlbs(struct kvm *kvm)
>  {
>         kvm_call_hyp(__kvm_tlb_flush_vmid, &kvm->arch.mmu);
> +       ++kvm->stat.generic.remote_tlb_flush;
>  }
>
>  static bool kvm_is_device_pfn(unsigned long pfn)
> --
> 2.31.1
>
> _______________________________________________
> kvmarm mailing list
> kvmarm@lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm