Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Jul 2021 15:25:13 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Shanker R Donthineni <sdonthineni@nvidia.com>
Cc:     Amey Narkhede <ameynarkhede03@gmail.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        alex.williamson@redhat.com,
        Raphael Norwitz <raphael.norwitz@nutanix.com>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        kw@linux.com, Sinan Kaya <okaya@kernel.org>,
        Len Brown <lenb@kernel.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v10 2/8] PCI: Add new array for keeping track of ordering
 of reset methods
Message-ID: <20210728202513.GA848092@bjorn-Precision-5520>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f89b5c62-56d5-3437-f8e7-24c5d74a7afa@nvidia.com>
Precedence: bulk

On Wed, Jul 28, 2021 at 01:31:19PM -0500, Shanker R Donthineni wrote:
> Hi Bjorn,
> 
> On 7/27/21 5:59 PM, Bjorn Helgaas wrote:
> >> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> >> index fefa6d7b3..42440cb10 100644
> >> --- a/drivers/pci/pci.c
> >> +++ b/drivers/pci/pci.c
> >> @@ -72,6 +72,14 @@ static void pci_dev_d3_sleep(struct pci_dev *dev)
> >>               msleep(delay);
> >>  }
> >>
> >> +int pci_reset_supported(struct pci_dev *dev)
> >> +{
> >> +     u8 null_reset_methods[PCI_NUM_RESET_METHODS] = { 0 };
> >> +
> >> +     return memcmp(null_reset_methods,
> >> +                   dev->reset_methods, sizeof(null_reset_methods));
> > I think "return dev->reset_methods[0] != 0;" is sufficient, isn't it?
> >
> 
> Agree with you, it simplifies code logic and can be moved to
> "include/linux/pci.h" with inline definition. Can we change return
> type to 'bool' instead of 'int' ?

Does it need to be exported to drivers?  Looks like it's only used
inside drivers/pci/, so it shouldn't be in include/linux/pci.h.

Making it bool is fine with me.

> static inline bool pci_reset_supported(struct pci_dev *dev)
> {??
> ??? return !!dev->reset_methods[0];
> }
>