Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 28 Jul 2021 20:44:33 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Nadav Amit <nadav.amit@gmail.com>
Cc:     Reiji Watanabe <reijiw@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, KVM <kvm@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 46/46] KVM: x86: Preserve guest's CR0.CD/NW on INIT
Message-ID: <YQHBsbHYayhSJOSz@google.com>
References: <20210713163324.627647-1-seanjc@google.com>
 <20210713163324.627647-47-seanjc@google.com>
 <CAAeT=FzGDUr8MK5Uf3jyUxtf+2jCf=bgG760L0mjjM3vRsXKSg@mail.gmail.com>
 <A41676B6-2E9F-4F8E-B91E-8F9A077A2FA8@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A41676B6-2E9F-4F8E-B91E-8F9A077A2FA8@gmail.com>
Precedence: bulk

On Mon, Jul 26, 2021, Nadav Amit wrote:
> 
> > On Jul 19, 2021, at 9:37 PM, Reiji Watanabe <reijiw@google.com> wrote:
> > 
> > On Tue, Jul 13, 2021 at 9:35 AM Sean Christopherson <seanjc@google.com> wrote:
> >> 
> >> Preserve CR0.CD and CR0.NW on INIT instead of forcing them to '1', as
> >> defined by both Intel's SDM and AMD's APM.
> >> 
> >> Note, current versions of Intel's SDM are very poorly written with
> >> respect to INIT behavior.  Table 9-1. "IA-32 and Intel 64 Processor
> >> States Following Power-up, Reset, or INIT" quite clearly lists power-up,
> >> RESET, _and_ INIT as setting CR0=60000010H, i.e. CD/NW=1.  But the SDM
> >> then attempts to qualify CD/NW behavior in a footnote:
> >> 
> >>  2. The CD and NW flags are unchanged, bit 4 is set to 1, all other bits
> >>     are cleared.
> >> 
> >> Presumably that footnote is only meant for INIT, as the RESET case and
> >> especially the power-up case are rather non-sensical.  Another footnote
> >> all but confirms that:
> >> 
> >>  6. Internal caches are invalid after power-up and RESET, but left
> >>     unchanged with an INIT.
> >> 
> >> Bare metal testing shows that CD/NW are indeed preserved on INIT (someone
> >> else can hack their BIOS to check RESET and power-up :-D).
> >> 
> >> Reported-by: Reiji Watanabe <reijiw@google.com>
> >> Signed-off-by: Sean Christopherson <seanjc@google.com>
> > 
> > Reviewed-by: Reiji Watanabe <reijiw@google.com>
> > 
> > Thank you for the fix and checking the CD/NW with the bare metal testing.
> 
> Interesting.
> 
> Is there a kvm-unit-test to reproduce the issue by any chance?

No :-/