Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH v10 2/8] PCI: Add new array for keeping track of ordering
 of reset methods
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     Amey Narkhede <ameynarkhede03@gmail.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        <alex.williamson@redhat.com>,
        Raphael Norwitz <raphael.norwitz@nutanix.com>,
        <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kw@linux.com>, Sinan Kaya <okaya@kernel.org>,
        Len Brown <lenb@kernel.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>
References: <20210728202513.GA848092@bjorn-Precision-5520>
From:   Shanker R Donthineni <sdonthineni@nvidia.com>
Message-ID: <3382bb94-0cf1-52eb-1b97-69b4536f4874@nvidia.com>
Date:   Wed, 28 Jul 2021 17:01:42 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210728202513.GA848092@bjorn-Precision-5520>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2021 22:01:45.5054
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 19eecdbc-dbff-41a7-a7d8-08d952134a78
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT054.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2684
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/28/21 3:25 PM, Bjorn Helgaas wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, Jul 28, 2021 at 01:31:19PM -0500, Shanker R Donthineni wrote:
>> Hi Bjorn,
>>
>> On 7/27/21 5:59 PM, Bjorn Helgaas wrote:
>>>> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
>>>> index fefa6d7b3..42440cb10 100644
>>>> --- a/drivers/pci/pci.c
>>>> +++ b/drivers/pci/pci.c
>>>> @@ -72,6 +72,14 @@ static void pci_dev_d3_sleep(struct pci_dev *dev)
>>>>               msleep(delay);
>>>>  }
>>>>
>>>> +int pci_reset_supported(struct pci_dev *dev)
>>>> +{
>>>> +     u8 null_reset_methods[PCI_NUM_RESET_METHODS] = { 0 };
>>>> +
>>>> +     return memcmp(null_reset_methods,
>>>> +                   dev->reset_methods, sizeof(null_reset_methods));
>>> I think "return dev->reset_methods[0] != 0;" is sufficient, isn't it?
>>>
>> Agree with you, it simplifies code logic and can be moved to
>> "include/linux/pci.h" with inline definition. Can we change return
>> type to 'bool' instead of 'int' ?
> Does it need to be exported to drivers?  Looks like it's only used
> inside drivers/pci/, so it shouldn't be in include/linux/pci.h.

Yes, you're right can be moved to driver/pci/pci.h.

> Making it bool is fine with me.
>
>> static inline bool pci_reset_supported(struct pci_dev *dev)
>> {  
>>     return !!dev->reset_methods[0];
>> }
>>