Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5636741pxv; Wed, 28 Jul 2021 16:03:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUiJFVP/+IWNsM2LnSdLvdWjEUbJBOQPHR+VLBheWyFq8WfyrZdbBSCrh+PbH8FJO64WBP X-Received: by 2002:a92:cb4d:: with SMTP id f13mr1529339ilq.57.1627513422302; Wed, 28 Jul 2021 16:03:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627513422; cv=none; d=google.com; s=arc-20160816; b=Ix9EV/4r+7Y5LSYSDEY053qaK0jbrNrasE6/XP3OQptwEkmJDVWWx1bD3qAsBzq6tT H0ofPM8oMDxROv54K3PMzwtuspS3WToEXk1RSSHAfz1LZyO28v6ViPC9GSRdxIjW5uTU Z+R3WBExAAL67Vej5I5ErzGJm6ST57fnriHok9uLVsMmlMPXpW3eKa/78SPevV6sNOjm ET5ZINiYJX1A7uXRC7hO81oVCFAvQbcnUog8kVkssmHKfjlTHzrlpYyjL4Xuc+AH44nf rTg+mLYr/azGDAN/9LriohGjWpAZ/1Z+9K8SIhEOhq+DDGg36d1MaMIl4lPff6JmnOtT sfIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EW1pTqw0YEcZ24+jdn1CJL3k17X+sqglrHQsZ+uJu9U=; b=hVM4dGJnYBn+hbHPMYsd/9Fl8T3uO1+obZ5aKV9DDxrFg1vw1ZyunirphNo8F7PNtF yW1DGtSg4Z/hfflS2A4w4TJ72E77f3s1vZj31INPirPzRIBGE0IReU/St9pf3f0A0eWS hO0mkUWq8QP8Sh/xFfzYXeXRo5/Wkb/8WCNoLYy7xVZjOcI608UrzyqDMMG0b3lZBpAi Jaup2Tzt3kiAHwfcu3sc/Ge3VhsGfwzITx0XvwVKzuwUSWBJ2uPkP+7daKHm49NGi0A/ egRJZ16ua1mTkRjQYGrB9zk/EX2bh/zMyStLjhXrZTrPkX8MblJKYkxfUcUoe45eyyoN buRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m6si1332767iol.83.2021.07.28.16.03.30; Wed, 28 Jul 2021 16:03:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232546AbhG1XCp (ORCPT + 99 others); Wed, 28 Jul 2021 19:02:45 -0400 Received: from mail-io1-f51.google.com ([209.85.166.51]:34708 "EHLO mail-io1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232452AbhG1XCm (ORCPT ); Wed, 28 Jul 2021 19:02:42 -0400 Received: by mail-io1-f51.google.com with SMTP id y200so4675689iof.1; Wed, 28 Jul 2021 16:02:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EW1pTqw0YEcZ24+jdn1CJL3k17X+sqglrHQsZ+uJu9U=; b=FF+YUdmLsF56dXVUPvZNy/OgfpL4G95EDZ6VsxKJKwdosgCl3mVyeFjw5vWKDv6DhT UK2tgG646lruhT0yAAiBfSkRPnw0IZZHUUWHbdexmmW0oaCD1XE04NmPmZCg0GD2r8wl /ziQ2C2LYOvhL+yrIDqdNVgAceXBU8DOiLwPpZFAtHBB85kFoyzTkDyU8cxzr9dLq8Qu LAyj+X5fd3F4p2Dhh2aCXkIAXqMAM8xO7+cLG5b0t46ko+LvlYTEwOBstToDqo++GCV5 GqIf3HzqXc5R7DdEXcuunr1nsxVLiyRtAA+dq5jduuKl4xV1wqXxTAzoOsWzeKudfmya yMlA== X-Gm-Message-State: AOAM532otT9OgpO2pMAYeG7Qz6cIoAOBabNia99OzPWGvYifiGQ/+tNc dPcLXYzPpslmCUFLCIaC5g== X-Received: by 2002:a5e:a818:: with SMTP id c24mr1450286ioa.180.1627513358799; Wed, 28 Jul 2021 16:02:38 -0700 (PDT) Received: from xps15.herring.priv ([64.188.179.248]) by smtp.googlemail.com with ESMTPSA id j20sm974821ile.17.2021.07.28.16.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 16:02:37 -0700 (PDT) From: Rob Herring To: Peter Zijlstra , Mark Rutland , Will Deacon , Kan Liang , Andy Lutomirski Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , linux-perf-users@vger.kernel.org Subject: [RFC 1/3] x86: perf: Move RDPMC event flag to a common definition Date: Wed, 28 Jul 2021 17:02:28 -0600 Message-Id: <20210728230230.1911468-2-robh@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210728230230.1911468-1-robh@kernel.org> References: <20210728230230.1911468-1-robh@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enable user counter access on arm64 and to move some of the user access handling to perf core, create a common event flag for user counter access and convert x86 to use it. Since the architecture specific flags start at the LSB, starting at the MSB for common flags. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Kan Liang Cc: Thomas Gleixner Cc: Borislav Petkov Cc: x86@kernel.org Cc: "H. Peter Anvin" Cc: linux-perf-users@vger.kernel.org Signed-off-by: Rob Herring --- arch/x86/events/core.c | 10 +++++----- arch/x86/events/perf_event.h | 2 +- include/linux/perf_event.h | 2 ++ 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c index 1eb45139fcc6..03f87fd4c017 100644 --- a/arch/x86/events/core.c +++ b/arch/x86/events/core.c @@ -2471,7 +2471,7 @@ static int x86_pmu_event_init(struct perf_event *event) if (READ_ONCE(x86_pmu.attr_rdpmc) && !(event->hw.flags & PERF_X86_EVENT_LARGE_PEBS)) - event->hw.flags |= PERF_X86_EVENT_RDPMC_ALLOWED; + event->hw.flags |= PERF_EVENT_FLAG_USER_READ_CNT; return err; } @@ -2503,7 +2503,7 @@ void perf_clear_dirty_counters(void) static void x86_pmu_event_mapped(struct perf_event *event, struct mm_struct *mm) { - if (!(event->hw.flags & PERF_X86_EVENT_RDPMC_ALLOWED)) + if (!(event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT)) return; /* @@ -2524,7 +2524,7 @@ static void x86_pmu_event_mapped(struct perf_event *event, struct mm_struct *mm) static void x86_pmu_event_unmapped(struct perf_event *event, struct mm_struct *mm) { - if (!(event->hw.flags & PERF_X86_EVENT_RDPMC_ALLOWED)) + if (!(event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT)) return; if (atomic_dec_and_test(&mm->context.perf_rdpmc_allowed)) @@ -2535,7 +2535,7 @@ static int x86_pmu_event_idx(struct perf_event *event) { struct hw_perf_event *hwc = &event->hw; - if (!(hwc->flags & PERF_X86_EVENT_RDPMC_ALLOWED)) + if (!(hwc->flags & PERF_EVENT_FLAG_USER_READ_CNT)) return 0; if (is_metric_idx(hwc->idx)) @@ -2718,7 +2718,7 @@ void arch_perf_update_userpage(struct perf_event *event, userpg->cap_user_time = 0; userpg->cap_user_time_zero = 0; userpg->cap_user_rdpmc = - !!(event->hw.flags & PERF_X86_EVENT_RDPMC_ALLOWED); + !!(event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT); userpg->pmc_width = x86_pmu.cntval_bits; if (!using_native_sched_clock() || !sched_clock_stable()) diff --git a/arch/x86/events/perf_event.h b/arch/x86/events/perf_event.h index 2bf1c7ea2758..84d803c5cc87 100644 --- a/arch/x86/events/perf_event.h +++ b/arch/x86/events/perf_event.h @@ -73,7 +73,7 @@ static inline bool constraint_match(struct event_constraint *c, u64 ecode) #define PERF_X86_EVENT_PEBS_NA_HSW 0x0010 /* haswell style datala, unknown */ #define PERF_X86_EVENT_EXCL 0x0020 /* HT exclusivity on counter */ #define PERF_X86_EVENT_DYNAMIC 0x0040 /* dynamic alloc'd constraint */ -#define PERF_X86_EVENT_RDPMC_ALLOWED 0x0080 /* grant rdpmc permission */ + #define PERF_X86_EVENT_EXCL_ACCT 0x0100 /* accounted EXCL event */ #define PERF_X86_EVENT_AUTO_RELOAD 0x0200 /* use PEBS auto-reload */ #define PERF_X86_EVENT_LARGE_PEBS 0x0400 /* use large PEBS */ diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 2d510ad750ed..f5815448ca9b 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -142,6 +142,8 @@ struct hw_perf_event { int event_base_rdpmc; int idx; int last_cpu; + +#define PERF_EVENT_FLAG_USER_READ_CNT 0x80000000 int flags; struct hw_perf_event_extra extra_reg; -- 2.27.0