Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5663068pxv; Wed, 28 Jul 2021 16:51:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAiWJCwuFyU4f7TG28wxvgBXnj8twPkGMfvYqLnD/HLJXc6kD+tuCO5nIYkSZWFAuYp/mP X-Received: by 2002:a17:906:2ad5:: with SMTP id m21mr1892015eje.88.1627516310441; Wed, 28 Jul 2021 16:51:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627516310; cv=none; d=google.com; s=arc-20160816; b=id3m/JxDw5SScs4IyWCD/yv6e6P51G4eAxlebYYHQcEdKVFVbQ14dMQBF8XmiDKU18 R69a3RBNWSmjImDYZYnMr4rjtMqURHkZeRWPcQsQ/tpyEoxV5hQBrTgHM0Gl2r5JstoY aM4/ZYG76O+tJiy3trTBX/E28nJe6udNibNX0N/Si07EyMjK50OTiw/mRZ9KmSK4/xfh raJGGdf+w34GB5HbAsIiM432SdWNvoc07flOTkR3xkwTE/Fu5NXAVUtbAf8eCUnPJyhp pXqla61iMUKebx1P4yYJoqUTQ/bN8V4dHA7ijxeOM4fo2XkhYf1TZLeyM7OjbKo3KuKJ orig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :dlp-version:dlp-reaction:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=Fh54VABHQ0P0uicPEPuXJ+6PLrobaVrf6vObaQ0A/Y0=; b=ZkFgCklxPWCfDcW3d3ofA5kxBh1xJpgrCHY7gwJXYCEJA6kUGsxd88DXYXoJ3U004+ zYDdYWuNBGK0D9SqIpyUdv3+Ch9w+nkI17yLQ+8/UrGX/sbGGxzhkGBUa1iBtvEll/7n Id1Dr5eiwbDkyOiTt21oOZulr8MEVSS9BR1kV00eA6y+7fHQ3RGdK0rj3h4kdGNRSyM4 mQaPqTMmDEreRbU2S+9HmPOIppAxbSfvEoRpS5+hUL947XNTgge70QGtkfvzPViMvctt Cq7a6KjL+9SmQsdYvieHwkKrU6/K7mHv7MtcLlPRXOygUtdXxftJO5rATXekDKjCULOv 0HFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t13si971152edc.254.2021.07.28.16.51.27; Wed, 28 Jul 2021 16:51:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232769AbhG1XsT convert rfc822-to-8bit (ORCPT + 99 others); Wed, 28 Jul 2021 19:48:19 -0400 Received: from mga18.intel.com ([134.134.136.126]:51286 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232641AbhG1XsS (ORCPT ); Wed, 28 Jul 2021 19:48:18 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10059"; a="199988469" X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="199988469" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2021 16:48:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="464860836" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 28 Jul 2021 16:48:16 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 28 Jul 2021 16:48:15 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 28 Jul 2021 16:48:14 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2242.010; Wed, 28 Jul 2021 16:48:14 -0700 From: "Luck, Tony" To: Sean Christopherson , "Hansen, Dave" CC: Jarkko Sakkinen , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages Thread-Topic: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC pages Thread-Index: AQHXg/G3voDWmDqCq06DL34grJaPratZaKWA//+WanCAAHqDAIAABZsA//+MGqA= Date: Wed, 28 Jul 2021 23:48:14 +0000 Message-ID: References: <20210719182009.1409895-1-tony.luck@intel.com> <20210728204653.1509010-1-tony.luck@intel.com> <20210728204653.1509010-2-tony.luck@intel.com> <17054ca5-0ef7-4b28-ab26-b1b96aa7403f@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - epc_page = sgx_alloc_epc_page(NULL, true); > + epc_page = sgx_alloc_epc_page(va_page, true); Providing a real value for the owner seems much better than all the hacks to invent a value to use instead of NULL. Can you add a "Signed-off-by"? Then I'll replace my part 0001 with your version. -Tony [Just need to coax you into re-writing all the other parts for me now :-) ]