Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Jul 2021 00:07:08 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     "Luck, Tony" <tony.luck@intel.com>
Cc:     "Hansen, Dave" <dave.hansen@intel.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] x86/sgx: Provide indication of life-cycle of EPC
 pages
Message-ID: <YQHxLG5fSTWPgez6@google.com>
References: <20210719182009.1409895-1-tony.luck@intel.com>
 <20210728204653.1509010-1-tony.luck@intel.com>
 <20210728204653.1509010-2-tony.luck@intel.com>
 <17054ca5-0ef7-4b28-ab26-b1b96aa7403f@intel.com>
 <f2685d7c8dc14792a4e0f9807f742ea6@intel.com>
 <fd8f8e79-f63f-7d6f-277e-1ad08ab7b6b8@intel.com>
 <YQHpGq0GyAsYpE+D@google.com>
 <b05acb65cebc4718a5cc2503ced7455d@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b05acb65cebc4718a5cc2503ced7455d@intel.com>
Precedence: bulk

On Wed, Jul 28, 2021, Luck, Tony wrote:
> > -       epc_page = sgx_alloc_epc_page(NULL, true);
> > +       epc_page = sgx_alloc_epc_page(va_page, true);
> 
> Providing a real value for the owner seems much better than all the hacks
> to invent a value to use instead of NULL.
> 
> Can you add a "Signed-off-by"? Then I'll replace my part 0001 with your version.

Signed-off-by: Sean Christopherson <seanjc@google.com>

> -Tony
> 
> [Just need to coax you into re-writing all the other parts for me now :-) ]

LOL, it might be easier to convince folks to just kill off SGX ;-)