Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210708183427.22842-1-bvanassche@acm.org> <9afbc59c-f745-03c1-c74d-264a7180ec87@acm.org>
In-Reply-To: <9afbc59c-f745-03c1-c74d-264a7180ec87@acm.org>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Thu, 29 Jul 2021 09:35:50 +0900
Message-ID: <CAC5umygRc0hRDrpO_fU=bo9sAJRsm9vxB3tAtTFpPYguEWB+Lw@mail.gmail.com>
Subject: Re: [PATCH] fault-inject: Declare the second argument of
 setup_fault_attr() const
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Jaegeuk Kim <jaegeuk@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2021=E5=B9=B47=E6=9C=8829=E6=97=A5(=E6=9C=A8) 8:05 Bart Van Assche <bvanass=
che@acm.org>:
>
> On 7/8/21 11:34 AM, Bart Van Assche wrote:
> > This patch makes it possible to pass a const char * argument to
> > setup_fault_attr() without having to cast away constness.
> >
> > Cc: Akinobu Mita <akinobu.mita@gmail.com>
> > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> > ---
> >   include/linux/fault-inject.h | 2 +-
> >   lib/fault-inject.c           | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.=
h
> > index e525f6957c49..afc649f0102b 100644
> > --- a/include/linux/fault-inject.h
> > +++ b/include/linux/fault-inject.h
> > @@ -42,7 +42,7 @@ struct fault_attr {
> >       }
> >
> >   #define DECLARE_FAULT_ATTR(name) struct fault_attr name =3D FAULT_ATT=
R_INITIALIZER
> > -int setup_fault_attr(struct fault_attr *attr, char *str);
> > +int setup_fault_attr(struct fault_attr *attr, const char *str);
> >   bool should_fail(struct fault_attr *attr, ssize_t size);
> >
> >   #ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
> > diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> > index ce12621b4275..45520151b32d 100644
> > --- a/lib/fault-inject.c
> > +++ b/lib/fault-inject.c
> > @@ -15,7 +15,7 @@
> >    * setup_fault_attr() is a helper function for various __setup handle=
rs, so it
> >    * returns 0 on error, because that is what __setup handlers do.
> >    */
> > -int setup_fault_attr(struct fault_attr *attr, char *str)
> > +int setup_fault_attr(struct fault_attr *attr, const char *str)
> >   {
> >       unsigned long probability;
> >       unsigned long interval;
>
> Hi Akinobu,
>
> Did I send this patch to the right person?

The fault injection patches are usually merged through the -mm tree.
Could you send this with CCing Andrew?

This patch looks good to me.

Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>