Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5698502pxv; Wed, 28 Jul 2021 17:57:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWy8Tl1BeieTWuLEkOXOAglMDFXnniBXNzTyux7pn0wbc5SjuxRZj4BGTB3YD0T25VXTky X-Received: by 2002:a02:a913:: with SMTP id n19mr2178873jam.7.1627520233808; Wed, 28 Jul 2021 17:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627520233; cv=none; d=google.com; s=arc-20160816; b=SB/pJ4vou9GQ5IYjk1r4Xxe9jLI01AJFXkOmJgoDZmJMH1xIXDhMT9xJcyecKbTVp/ TLLqM5h3W581WmRGuMMm4L15A4rZuYoOPm+XJHIqm2zwsLKSBRaFEcsAfonGql8SvA9e F9fUdAW2dAf2+GzkVCiGuGovQ4aXGGN5KuRkDVukyMqiurHSJXWkYZU2qoTYSXS1LOXf JXmvU458ELA/IbV60KkthUFi5bUEHWjFzDvB/FCsS1GO1ReWCYBB56YlR2WmU11GiwYI lrhwSVevseqak9719gciSRQh+x6kJ0bQNGQ6gHY8B2AaQ7CQt/IVhRA883yy/0lP7QCx 0h2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=epHRm1MPdCZ/8sEAyDU/l0p8OSyuJwUxffl4umSSVrg=; b=QOoqBjvGLo9jolEQUggj2JwzbBWPnFnnKgh4MqVhyzhQCjiJ6Mmn9B0dFz1A2sSYfN V1yCByrMmWV28yn1VqzKuuBSg3wo3Almohtj1qwMmMYTj3wguq0tjZRoYavgtvfJk7JB jzcYqGKxK1P67als7T32pUeqlDUwmzlob4FJrpZwVLbF9rMwVwtQ5x6DzkWwCCFyUTc+ SMEFP3ogvAb+htJw/KdIfEyC9P2+fFoo7VNAfPAec/78cM5+L+J3nzC6ZSU2qWwRW1f2 DLpZ7GC1REGtuxhee+Katg18/LqZcX+cyYxatBjFYZ/cWUjovgxFqykAY6pLoGmAvJi/ ByKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SFP9YXnc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si1423204ilo.83.2021.07.28.17.57.02; Wed, 28 Jul 2021 17:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SFP9YXnc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233098AbhG2Ayw (ORCPT + 99 others); Wed, 28 Jul 2021 20:54:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:50174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232837AbhG2Ayv (ORCPT ); Wed, 28 Jul 2021 20:54:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9EEC26101C; Thu, 29 Jul 2021 00:54:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627520089; bh=ySj2WLCx/U6vUSMi0vPV9bFB7St2XGwXoloT+C5A3Nw=; h=Subject:To:References:From:Date:In-Reply-To:From; b=SFP9YXncg5J/gGtO/esR7/KSWhcLNz1iJ5uG1SyKwNU7FtPsfj8o8gXd3BybRE4lF F9RpYK7o9OaHPVeBE82p8gZCA4coIrA2lTqV9gRrYygxFiHKdXIDLgLnRAaXZctbux s9eRq9YQn65n9TyZNVTHj7gBLxIRwgX+Ho7ajEEWjWkiKVKrxtMMBoqALXT3AMbulV w0MW5jgLNk4xWvOAFnCJw6YqxMMqmQA6R9aFuTwBERthv0KugWxLWSPgGiiX45FKrx XlWRpqJNzoJXiTsrPMPaqSnWjH3qtyS4OH3iCw3a2fR1zGp4LxH0kaBvPtV6f0GlJ8 7MUmaPeW23Evw== Subject: Re: [f2fs-dev] [PATCH] f2fs: do not submit NEW_ADDR to read node block To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20210726161357.105332-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <26d8629e-ade4-43e7-b95a-073809d59936@kernel.org> Date: Thu, 29 Jul 2021 08:54:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210726161357.105332-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/7/27 0:13, Jaegeuk Kim wrote: > After the below patch, give cp is errored, we drop dirty node pages. This > can give NEW_ADDR to read node pages. Don't do WARN_ON() which gives > generic/475 failure. > > Fixes: 28607bf3aa6f ("f2fs: drop dirty node pages when cp is in error status") > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,