Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Valdis Kletnieks <valdis@vt.edu>
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     Ian Pilcher <arequipeno@gmail.com>
Cc:     linux-block@vger.kernel.org, linux-leds@vger.kernel.org,
        axboe@kernel.dk, pavel@ucw.cz, linux-kernel@vger.kernel.org,
        kernelnewbies@kernelnewbies.org
Subject: Re: [RFC PATCH 1/8] docs: Add block device LED trigger documentation
In-Reply-To: <20210729015344.3366750-2-arequipeno@gmail.com>
References: <20210729015344.3366750-1-arequipeno@gmail.com>
 <20210729015344.3366750-2-arequipeno@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1627528155_13589P";
         micalg=pgp-sha256; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Wed, 28 Jul 2021 23:09:15 -0400
Message-ID: <108629.1627528155@turing-police>
Precedence: bulk

--==_Exmh_1627528155_13589P
Content-Type: text/plain; charset=us-ascii

On Wed, 28 Jul 2021 20:53:37 -0500, Ian Pilcher said:

> +Create a new block device LED trigger::
> +
> +	# echo foo > /sys/class/block/led_trigger_new
> +
> +The name must be unique among all LED triggers (not just block device LED
> +triggers).
> +
> +Create two more::
> +
> +	# echo bar baz > /sys/class/block/led_trigger_new

> +	# cat /sys/class/block/led_trigger_list
> +	baz: 0
> +	bar: 0
> +	foo: 0

This looks like an abuse of the "one entry one value" rule for sysfs.
Perhaps this should be a directory /sys/class/block/defined_triggers/
and separate files under that for foo, bar, and baz?  That would probably
make reference counting a lot easier as well....

--==_Exmh_1627528155_13589P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQEcBAEBCAAGBQJhAhvbAAoJEI0DS38y7CIctZEH/3Pdfz1JB35y9wFELHDki00R
/UC64FJqOqMfASDl0QtxgVV1S3MfGAAqXFlUw1Djb/0/ZcytyZ22f2S0u8JaP9Qx
M4Wr0eo5A/BLR7csFwxoxN7lfxDFyEcsKKx+kkZZgfmoqbTLzt46NXTRWrcxJ5p4
rc9KA6hWGz3GYFUj48Maz9VA3hNz3RLcmOy/F1DKHk7nwBrXZ775iKToao4uNNrw
Y0NNAAFQYQ8LBZkf5G2hxBakpIA5jY+7arv2dIDO6f+MyDQYKH8gvJEO1vFmiyMM
OAufuI4mM8ouhA11rIRqtZZ9acl12CJt/OK8FPifF+ypiFVqbqZHteNbzIvbmY4=
=IjcV
-----END PGP SIGNATURE-----

--==_Exmh_1627528155_13589P--