Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     Ye Bin <yebin10@huawei.com>, linux-kernel@vger.kernel.org,
        jejb@linux.ibm.com, linux-scsi@vger.kernel.org
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATH v2] scsi: scsi_dh_rdac: Avoid crash during rdac_bus_attach
Date:   Wed, 28 Jul 2021 23:37:08 -0400
Message-Id: <162752979292.3014.9865687646574128836.b4-ty@oracle.com>
In-Reply-To: <20210113063103.2698953-1-yebin10@huawei.com>
References: <20210113063103.2698953-1-yebin10@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.mkp.ca.oracle.com (138.3.201.9) by SJ0PR05CA0121.namprd05.prod.outlook.com (2603:10b6:a03:33d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.9 via Frontend Transport; Thu, 29 Jul 2021 03:37:21 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 19236cce-e560-4111-2aa1-08d952422ce6
X-MS-TrafficTypeDiagnostic: MWHPR10MB1549:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR10MB1549E345297A014521EE68A58EEB9@MWHPR10MB1549.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3513;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ziK4hG0gIyZcQwA/6YQ9Rwfb6bczK4+ed1m9oDDiHRwAzuhH52HekAMuZRNsgyuxCPVFSWqgAiShjkIBUy6IoNcDM9BEwrPTtwDUmnZr7ZLvfAyg+t7scyf+6I1gowomd09gAIFZtmEXznAJdcnLUvrY/D/jy0H6963XHWeQWPwvaEQn3Cx0eTLN61J2Nvnlz8SXalhNGPekE+8t6bntHa9N0mcMTNwgCGl8osuggNvkwf5mJG7Eu1TOiDvuPxME5mY500Ip6Fc3pxpMRlWLX6rwlpd4hf0c6f5DRcpgS9swZ7Mz0kMayCDf2rcRgPeVty+fSIDe0dOMlOjR1ppARpXrLQmye+JZL9d0D1kq5djOSRcdnLi9vyVHewlz+UWxfKeiB7xPxm/ckGZLipMsSSD0+qzYbGIkxzXkJ7iS227pqTyN22JLV2HYT9aeb8aJsb+FIZNICMDolZxFeDjc5sCHRC43Bnt1vclUclMxuYV+Zm7iK0qZaZEui9uhcKVTyerDgYj4W344d9ZhCrFrDzso5aRzWaRkT3fpQg8RS1bm9u3ERCONHI7XTsN1C3KAr5B7989SvprtF0x689VY8B5v0JnRy3rJNzh3GOrA6XgOsj4fLGe+yW5xIV1nsPIdZ22NBOnh/USgrIF6PF5HsTvejJ0FTbkM+H7z8ecNhYDsAMHSvLLqlcMntPhXoD5xMHKk5EbqfB+etezLY0rDWMyCOLRcI8MsLQNRx33h8PuN0PjcZFaHxDjStQ+t3hCJeSYdsPVddA3qoo8+AVDGwg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4754.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(66946007)(6486002)(26005)(2906002)(316002)(103116003)(6666004)(186003)(4326008)(38100700002)(38350700002)(5660300002)(36756003)(966005)(107886003)(8676002)(508600001)(52116002)(7696005)(2616005)(956004)(86362001)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEVoT29lZUxUcXhPekRIalBlZW5NVER2ZW5GZnk0cVVvYkYyYkxFWkcvVW9s?=
 =?utf-8?B?OFF4NmxoNHk0MnEzZFVSQ3Q0RlBYSldINUZEU0RWODJ3cmZObjlCdVh4b1Y3?=
 =?utf-8?B?ZVhPeThDc25ZNEpVSG5GbzA2djltcTlvSHlqNDVzY1FhRGxheWxrSHNoYUsy?=
 =?utf-8?B?K1h2UG56ZGxyUDFXcFpENHZGa0drWHdFN05QeGd0ZDRMOHhaR0NLWG9vb05i?=
 =?utf-8?B?WHpoL2JTeDF5RDIrR0RJdDFLSzZyWnp5OEo2TnljYTN4cHgwYTRydkJ5N3lx?=
 =?utf-8?B?N2NXUzQvdDg2dzZKM0RTcGh3MFVxOUMrM1Bjdm5TR0Q2aVdNU3lLb0dmcmx0?=
 =?utf-8?B?Tkh4aEJjS3QySWNCRmY0RTZya0ZPOHhvcGc1SWtzSEcxWlc1d21qOFBVRVE0?=
 =?utf-8?B?NWJQL1lBL3NoeC9WakU4OVBJalZSWEpUeEd4V2xIejh3cXZtTFhPTEFwSEpB?=
 =?utf-8?B?UHdoMm9OdFVTb20zdnNLRHVKSEdRNWtTWXBwSHZ4R0FEK2ptbnByRzY0VkF1?=
 =?utf-8?B?L3VkNHBzMjh3eHRxanE3c29JRnBZNGlxSTNqclFJY1ZtZ3lidkxuK0hLRDVW?=
 =?utf-8?B?d29QODBKL0doWnBYRitYR1F5R1ZycDJvbjNCQWsxZVJzZjBtYW0wNzdpZGpN?=
 =?utf-8?B?UFFaVFMxVmhVNmFMekk2YTF0V0xYUDhmWndENnd0dXZNaThDaUZiY0dSU1pG?=
 =?utf-8?B?MWZtZkJ5M1lyMDJXQUM0NndxcDg5c0Z4OEJFdWdzS1o5b213Ulk0Q3hWWGRm?=
 =?utf-8?B?N2F6bi92YTFsaWF2TDRnY056OFVTN08vNzRnQTV4T1VQcTVCZlV6djMyb1Ix?=
 =?utf-8?B?VEVCLzBBbzNRZ0k1NGRRWnQ3UHBTSTV6UTJyTkhnQTc0WHBpMXN5Zk5QNGF4?=
 =?utf-8?B?Ukt0VFAzY1g1MEwxaVdvKzBYN09sU1hZUHZGV21HY3huSit1SlJ0NjNIa3lj?=
 =?utf-8?B?QVZ5WitaRmdncVJjeXVRT0dDd3Zmb3FLYXFzdVRzUlpPREhXckRBVElWMGNZ?=
 =?utf-8?B?UjNiNkZ3K3k3bm1BYXpBSkZqeWZzcXpXRDlyUGR6WGxxT0ZxSzVCbFRONHFm?=
 =?utf-8?B?VDVlblpSV3lmUlhIdW5YS1JDZ0ZwcnY0WkFKS3IrZFZhZWVzVkhvR1BtalIy?=
 =?utf-8?B?YkE5MVdWcy93TVVySlVBN1hVRHNkTzJMbGdhdGF0dUkwWTBEQ2JjVjMzL1ZJ?=
 =?utf-8?B?QkpFRThSK2ZLdktLRkNoRmR1TmR0enA2V1dqUnpXYkhXK1JFNWtIeEd4M0Vi?=
 =?utf-8?B?QTRTVlpOMnBjS25wa2hTWDRwbXVBTWxBcmY5SjdxSGdJemhRWWZqSis4WDN1?=
 =?utf-8?B?WVpLMDJNOTdhcHYwekNkNUlEN3ZBazd5bnp5U25JWi9uM1NGSzlRMzRQbTBq?=
 =?utf-8?B?aldlTzRaMGpmK3FoS0c1Z0Y4dWgxK0Y4eXV4VFlZNFdSc2dmd0lCL0hiNTJh?=
 =?utf-8?B?QXF2RGMyQStoeTZkT2RSNzZ3c0RURFI5NTArenI1clpBZWlrZGk4YkFjUlhL?=
 =?utf-8?B?UzBIUUFpWU9lVzZsMmFHMEtiTVVaMzcwbnZjbm1wVmVuRVlncmFUeGprb0kv?=
 =?utf-8?B?c090QWdHemlhdmJyc0p3ZmFyaTBrNXIvVDF3TVFtTUEvaG1GRkNvNkdjREFX?=
 =?utf-8?B?NFdJVG9vb1BOUHJ0M2JrMC8wRFRDQ290M1Vid0pkZFc4LzVlT0QvTnlQN1ZW?=
 =?utf-8?B?aWl4Zmx5cVpKdXp1dE8xSG1JenNkNmM0QUVvZ0xtaU5xVHZmRUhOQ0F5THFS?=
 =?utf-8?Q?KPFqgmOcLWpgh444g+DsdLw4NOq/9M0QZN0jibZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19236cce-e560-4111-2aa1-08d952422ce6
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4754.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 03:37:22.6098
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2UgQ4f6/s+BBeSO8KHEXCRT8666o+AutjH2x8T+oscjxeKNHPM2bCQlJugZhxt0tMBDO8EZRF/pwoV4qX12ncdqRt4efw+EnD3Mr3KNpfK8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1549
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10059 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=933 bulkscore=0 spamscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2107290020
X-Proofpoint-ORIG-GUID: TdA4jw9ghSfhGsbPY4rFkCDbN5QaDTOQ
X-Proofpoint-GUID: TdA4jw9ghSfhGsbPY4rFkCDbN5QaDTOQ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 13 Jan 2021 14:31:03 +0800, Ye Bin wrote:

> We get follow BUG_ON when rdac scan:
> [595952.944297] kernel BUG at drivers/scsi/device_handler/scsi_dh_rdac.c:427!
> [595952.951143] Internal error: Oops - BUG: 0 [#1] SMP
> ......
> [595953.251065] Call trace:
> [595953.259054]  check_ownership+0xb0/0x118
> [595953.269794]  rdac_bus_attach+0x1f0/0x4b0
> [595953.273787]  scsi_dh_handler_attach+0x3c/0xe8
> [595953.278211]  scsi_dh_add_device+0xc4/0xe8
> [595953.282291]  scsi_sysfs_add_sdev+0x8c/0x2a8
> [595953.286544]  scsi_probe_and_add_lun+0x9fc/0xd00
> [595953.291142]  __scsi_scan_target+0x598/0x630
> [595953.295395]  scsi_scan_target+0x120/0x130
> [595953.299481]  fc_user_scan+0x1a0/0x1c0 [scsi_transport_fc]
> [595953.304944]  store_scan+0xb0/0x108
> [595953.308420]  dev_attr_store+0x44/0x60
> [595953.312160]  sysfs_kf_write+0x58/0x80
> [595953.315893]  kernfs_fop_write+0xe8/0x1f0
> [595953.319888]  __vfs_write+0x60/0x190
> [595953.323448]  vfs_write+0xac/0x1c0
> [595953.326836]  ksys_write+0x74/0xf0
> [595953.330221]  __arm64_sys_write+0x24/0x30
> 
> [...]

Applied to 5.14/scsi-fixes, thanks!

[1/1] scsi: scsi_dh_rdac: Avoid crash during rdac_bus_attach
      https://git.kernel.org/mkp/scsi/c/fb5d909021b4

-- 
Martin K. Petersen	Oracle Linux Engineering